Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <5a3e440f-4ec5-65d7-b2a4-c57fec0df973@infradead.org> <CAHk-=wg4mE8pSEdWViqJBC9Teh8h1c9LrqqP6=_g8ud5hvkfmA@mail.gmail.com>
In-Reply-To: <CAHk-=wg4mE8pSEdWViqJBC9Teh8h1c9LrqqP6=_g8ud5hvkfmA@mail.gmail.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun, 1 Sep 2019 10:31:22 -0700
Message-ID: <CAHk-=whH+Wzj+h0WzgdLMu+xtFddokoVy8dWWvEJqJRGA_HLmw@mail.gmail.com>
Subject: Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        "Steven J. Magnani" <steve@digidescorp.com>,
        Michal Simek <monstr@monstr.eu>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Leon Romanovsky <leonro@mellanox.com>,
        Doug Ledford <dledford@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: multipart/mixed; boundary="00000000000054c4cf0591813a94"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--00000000000054c4cf0591813a94
Content-Type: text/plain; charset="UTF-8"

On Sun, Sep 1, 2019 at 10:07 AM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I guess I'll apply it. I'm not sure why you _care_ about microblaze, but ...

Ugh. As I was going to apply it, my code cleanliness conscience struck.

I can't deal with that unnecessary duplication of code. Does something
like the attached patch work instead?

Totally untested, but looks much cleaner.

               Linus

--00000000000054c4cf0591813a94
Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_k019380r0>
X-Attachment-Id: f_k019380r0

IGFyY2gvbWljcm9ibGF6ZS9pbmNsdWRlL2FzbS91YWNjZXNzLmggfCA0MiArKysrKysrKy0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwg
MzMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC9taWNyb2JsYXplL2luY2x1ZGUvYXNt
L3VhY2Nlc3MuaCBiL2FyY2gvbWljcm9ibGF6ZS9pbmNsdWRlL2FzbS91YWNjZXNzLmgKaW5kZXgg
YmZmMmE3MWM4MjhhLi44OGJkZTA2YTQxYTMgMTAwNjQ0Ci0tLSBhL2FyY2gvbWljcm9ibGF6ZS9p
bmNsdWRlL2FzbS91YWNjZXNzLmgKKysrIGIvYXJjaC9taWNyb2JsYXplL2luY2x1ZGUvYXNtL3Vh
Y2Nlc3MuaApAQCAtMTYzLDQ0ICsxNjMsMTUgQEAgZXh0ZXJuIGxvbmcgX191c2VyX2JhZCh2b2lk
KTsKICAqIFJldHVybnMgemVybyBvbiBzdWNjZXNzLCBvciAtRUZBVUxUIG9uIGVycm9yLgogICog
T24gZXJyb3IsIHRoZSB2YXJpYWJsZSBAeCBpcyBzZXQgdG8gemVyby4KICAqLwotI2RlZmluZSBn
ZXRfdXNlcih4LCBwdHIpCQkJCQkJXAotCV9fZ2V0X3VzZXJfY2hlY2soKHgpLCAocHRyKSwgc2l6
ZW9mKCoocHRyKSkpCi0KLSNkZWZpbmUgX19nZXRfdXNlcl9jaGVjayh4LCBwdHIsIHNpemUpCQkJ
CQlcCi0oewkJCQkJCQkJCVwKLQl1bnNpZ25lZCBsb25nIF9fZ3VfdmFsID0gMDsJCQkJCVwKLQlj
b25zdCB0eXBlb2YoKihwdHIpKSBfX3VzZXIgKl9fZ3VfYWRkciA9IChwdHIpOwkJCVwKLQlpbnQg
X19ndV9lcnIgPSAwOwkJCQkJCVwKLQkJCQkJCQkJCVwKLQlpZiAoYWNjZXNzX29rKF9fZ3VfYWRk
ciwgc2l6ZSkpIHsJCQlcCi0JCXN3aXRjaCAoc2l6ZSkgewkJCQkJCVwKLQkJY2FzZSAxOgkJCQkJ
CQlcCi0JCQlfX2dldF91c2VyX2FzbSgibGJ1IiwgX19ndV9hZGRyLCBfX2d1X3ZhbCwJXAotCQkJ
CSAgICAgICBfX2d1X2Vycik7CQkJXAotCQkJYnJlYWs7CQkJCQkJXAotCQljYXNlIDI6CQkJCQkJ
CVwKLQkJCV9fZ2V0X3VzZXJfYXNtKCJsaHUiLCBfX2d1X2FkZHIsIF9fZ3VfdmFsLAlcCi0JCQkJ
ICAgICAgIF9fZ3VfZXJyKTsJCQlcCi0JCQlicmVhazsJCQkJCQlcCi0JCWNhc2UgNDoJCQkJCQkJ
XAotCQkJX19nZXRfdXNlcl9hc20oImx3IiwgX19ndV9hZGRyLCBfX2d1X3ZhbCwJXAotCQkJCSAg
ICAgICBfX2d1X2Vycik7CQkJXAotCQkJYnJlYWs7CQkJCQkJXAotCQlkZWZhdWx0OgkJCQkJCVwK
LQkJCV9fZ3VfZXJyID0gX191c2VyX2JhZCgpOwkJCVwKLQkJCWJyZWFrOwkJCQkJCVwKLQkJfQkJ
CQkJCQlcCi0JfSBlbHNlIHsJCQkJCQkJXAotCQlfX2d1X2VyciA9IC1FRkFVTFQ7CQkJCQlcCi0J
fQkJCQkJCQkJXAotCXggPSAoX19mb3JjZSB0eXBlb2YoKihwdHIpKSlfX2d1X3ZhbDsJCQkJXAot
CV9fZ3VfZXJyOwkJCQkJCQlcCisjZGVmaW5lIGdldF91c2VyKHgsIHB0cikgKHsJCQkJXAorCXR5
cGVvZihwdHIpIF9fZ3VfcHRyID0gKHB0cik7CQkJXAorCWFjY2Vzc19vayhfX2d1X3B0ciwgc2l6
ZW9mKCpfX2d1X3B0cikpID8JXAorCQlfX2dldF91c2VyKHgsIF9fZ3VfcHRyKSA6IC1FRkFVTFQ7
CVwKIH0pCiAKICNkZWZpbmUgX19nZXRfdXNlcih4LCBwdHIpCQkJCQkJXAogKHsJCQkJCQkJCQlc
CiAJdW5zaWduZWQgbG9uZyBfX2d1X3ZhbCA9IDA7CQkJCQlcCi0JLyp1bnNpZ25lZCBsb25nIF9f
Z3VfcHRyID0gKHVuc2lnbmVkIGxvbmcpKHB0cik7Ki8JCVwKIAlsb25nIF9fZ3VfZXJyOwkJCQkJ
CQlcCiAJc3dpdGNoIChzaXplb2YoKihwdHIpKSkgewkJCQkJXAogCWNhc2UgMToJCQkJCQkJCVwK
QEAgLTIxMiw2ICsxODMsMTEgQEAgZXh0ZXJuIGxvbmcgX191c2VyX2JhZCh2b2lkKTsKIAljYXNl
IDQ6CQkJCQkJCQlcCiAJCV9fZ2V0X3VzZXJfYXNtKCJsdyIsIChwdHIpLCBfX2d1X3ZhbCwgX19n
dV9lcnIpOwlcCiAJCWJyZWFrOwkJCQkJCQlcCisJY2FzZSA4OgkJCQkJCQkJXAorCQlfX2d1X2Vy
ciA9IF9fY29weV9mcm9tX3VzZXIoJl9fZ3VfdmFsLCBwdHIsIDgpOwkJXAorCQlpZiAoX19ndV9l
cnIpCQkJCQkJXAorCQkJX19ndV9lcnIgPSAtRUZBVUxUOwkJCQlcCisJCWJyZWFrOwkJCQkJCQlc
CiAJZGVmYXVsdDoJCQkJCQkJXAogCQkvKiBfX2d1X3ZhbCA9IDA7IF9fZ3VfZXJyID0gLUVJTlZB
TDsqLyBfX2d1X2VyciA9IF9fdXNlcl9iYWQoKTtcCiAJfQkJCQkJCQkJXAo=
--00000000000054c4cf0591813a94--