Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Christoph Hellwig <hch@lst.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        =?iso-8859-1?Q?Thomas_Hellstr=F6m?= <thomas@shipmail.org>,
        Jerome Glisse <jglisse@redhat.com>,
        Steven Price <steven.price@arm.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Hellstrom <thellstrom@vmware.com>
Subject: Re: [PATCH 2/3] pagewalk: separate function pointers from iterator
 data
Thread-Topic: [PATCH 2/3] pagewalk: separate function pointers from iterator
 data
Thread-Index: AQHVXauzoOyMGt/Rm0+/Xu8LAWoHTqcXL4MAgAAOHoA=
Date:   Sun, 1 Sep 2019 19:36:04 +0000
Message-ID: <20190901193601.GB5208@mellanox.com>
References: <20190828141955.22210-1-hch@lst.de>
 <20190828141955.22210-3-hch@lst.de> <20190901184530.GA18656@roeck-us.net>
In-Reply-To: <20190901184530.GA18656@roeck-us.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.168.164.202]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b0e66951-a2b0-4fd6-683c-08d72f13a071
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB5407;
x-ms-traffictypediagnostic: VI1PR05MB5407:
x-microsoft-antispam-prvs: <VI1PR05MB5407325816E8C3007A00F570CFBF0@VI1PR05MB5407.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:773;
x-forefront-prvs: 0147E151B5
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(376002)(396003)(136003)(366004)(346002)(189003)(199004)(25786009)(4326008)(6512007)(6436002)(6246003)(6486002)(1076003)(7416002)(53936002)(6916009)(33656002)(14444005)(36756003)(256004)(71190400001)(71200400001)(86362001)(64756008)(66556008)(66476007)(7736002)(8676002)(81166006)(81156014)(5660300002)(2906002)(66946007)(55236004)(66446008)(229853002)(99286004)(446003)(14454004)(11346002)(386003)(6506007)(186003)(6116002)(52116002)(26005)(102836004)(3846002)(76176011)(316002)(486006)(54906003)(305945005)(8936002)(66066001)(2616005)(476003)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB5407;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 2H/j1oARbAJtKOVJKSQqJFFv+h6ipUsCvwwYYdm5zqVKw9Ez2G3SnEsBEpNA1CndH0AeiDkhf08CI4ehmWa0hZGrUEmrADuqazImYReADHhm1bEf4ZWEvhCnzq0CaEdJftpumTSwfzAizQN+wKB0rOGr7oa60gdVSk45kKHwARrgIM3wudPiMatpNUSnmgCsbyc5Rdjv9/rFrjyg0qY5sfO3SvBLZONOpZ6vEqP0e0k+lAXlwiARdFHKUIw2UPAftubwAJMZDS69tfI0iMLqvUXv0g/an5S/l/x0zoDgc0BlIpSxn2I8jZta3mOT5YOupE/U8P1WuCRKBfQ4LsRtjUiSOAiqrwCWVuWnbEOTsNVIhVgogjOC3I3+iKJGduedyxcmxTshXtNEmnXLsL7mcqAEEYpIyhy1s3P4mSPKosY=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <AC51C72B4393ED4E95D4C3B5363384DE@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0e66951-a2b0-4fd6-683c-08d72f13a071
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2019 19:36:04.0184
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rjv2JEheY8Wkh8x2OIbus5T2sUEVI1CMh3ek2LTXnsSK/pgZ67NLwEUsSdSdp+IY0O9IL3rR5B+IEKKscsrK6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5407
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 01, 2019 at 11:45:30AM -0700, Guenter Roeck wrote:
> On Wed, Aug 28, 2019 at 04:19:54PM +0200, Christoph Hellwig wrote:
> > The mm_walk structure currently mixed data and code.  Split out the
> > operations vectors into a new mm_walk_ops structure, and while we
> > are changing the API also declare the mm_walk structure inside the
> > walk_page_range and walk_page_vma functions.
> >=20
> > Based on patch from Linus Torvalds.
> >=20
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
> > Reviewed-by: Steven Price <steven.price@arm.com>
> > Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
>=20
> When building csky:defconfig:
>=20
> In file included from mm/madvise.c:30:
> mm/madvise.c: In function 'madvise_free_single_vma':
> arch/csky/include/asm/tlb.h:11:11: error:
> 	invalid type argument of '->' (have 'struct mmu_gather')

I belive the macros above are missing brackets.. Can you confirm the
below takes care of things? I'll add a patch if so

diff --git a/arch/csky/include/asm/tlb.h b/arch/csky/include/asm/tlb.h
index 8c7cc097666f04..fdff9b8d70c811 100644
--- a/arch/csky/include/asm/tlb.h
+++ b/arch/csky/include/asm/tlb.h
@@ -8,14 +8,14 @@
=20
 #define tlb_start_vma(tlb, vma) \
 	do { \
-		if (!tlb->fullmm) \
-			flush_cache_range(vma, vma->vm_start, vma->vm_end); \
+		if (!(tlb)->fullmm) \
+			flush_cache_range(vma, (vma)->vm_start, (vma)->vm_end); \
 	}  while (0)
=20
 #define tlb_end_vma(tlb, vma) \
 	do { \
-		if (!tlb->fullmm) \
-			flush_tlb_range(vma, vma->vm_start, vma->vm_end); \
+		if (!(tlb)->fullmm) \
+			flush_tlb_range(vma, (vma)->vm_start, (vma)->vm_end); \
 	}  while (0)
=20
 #define tlb_flush(tlb) flush_tlb_mm((tlb)->mm)

Thanks,
Jason