Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp37879ybe; Sun, 1 Sep 2019 19:55:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqzm3Y0ZPe8uQzLXyHgIYKlcRwsAMZzKKBC0evGne15n582N07tkPHoGI7XtwyX9L6nJ1tPH X-Received: by 2002:a63:ee0c:: with SMTP id e12mr23940932pgi.184.1567392934646; Sun, 01 Sep 2019 19:55:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567392934; cv=none; d=google.com; s=arc-20160816; b=dnLpFbU6KQEpeREeo1WZ+W8iKxDKl6/dr6Kmx2psSnSG9JkDYAS8OoEaJYJBnUEBeG A/YV5dRIRmNfW8veWXH61JdWeVLlLRR2Pd6kiFvkqx5hqMOTGzTBxmgqaHJIpJ2XgEXh R4dq2m+xS74apid5U/Y6uGNlAHMuQcRLdyZQBrZdeg9+PUK7HMqetL9CCvK7U7k43Bqj GnlXt1+jLpnF/5E/4FsDyBhuQnr/yQnJtNz9HLRRil2e9uJh6HS/31x9oR8Eg3VFaIm1 95lyX2UQ+2HR+o1Nsj/ozYUMdGvn31AgyY4VE3u/P5Igz+kp7dDWojfWY6cpni5Ys917 KxTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from; bh=W1XORcA3dA965B2wu/iZL+nSXEcO56WCuWlm9VxSHo8=; b=berRNjwlhhJ+aN5yrVkDQeMAFoknRrhAgC7X7AhxTgwJv0zMXEaMbwYVVP1CvzeEzm rU0zIG5uCKNYBxrOfpCoBK/jQ1UJETXvv8Blvk2w9due//Y/3i46Z/Fdzwu4nEE19vIb mooq6eLJZ46GeV4iIHSHMnyHKhyF1KjeoI7jljGeMrQrJPUAEAEq6jzIVs+xo+fVfLXW zXwsuOJG5e0nq6lGLR8x5e4jNMnyjIoBzoEbd62mFh3b8JOi0na6WArvtrs2JYrdXvD3 bDmZsffLjLZyzylMUX2T12Vnw2zKELAKmyELjh4y9Qbcrr9kROotzDoVkrv/e6HPfwu/ PTyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k25si12439406pfi.265.2019.09.01.19.54.44; Sun, 01 Sep 2019 19:55:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729268AbfIBCvv convert rfc822-to-8bit (ORCPT + 99 others); Sun, 1 Sep 2019 22:51:51 -0400 Received: from ozlabs.org ([203.11.71.1]:41891 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729255AbfIBCvv (ORCPT ); Sun, 1 Sep 2019 22:51:51 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 46MF3P6ZMkz9sBF; Mon, 2 Sep 2019 12:51:45 +1000 (AEST) From: Michael Ellerman To: Michal =?utf-8?Q?Such=C3=A1nek?= , linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Christophe Leroy , Nicholas Piggin , Hari Bathini , Joel Stanley , Andrew Donnellan , Firoz Khan , Breno Leitao , Russell Currey , Nicolai Stange , Michael Neuling , "Eric W. Biederman" , Thomas Gleixner , Arnd Bergmann , Geert Uytterhoeven , Heiko Carstens , Christian Brauner , David Howells , Greg Kroah-Hartman , Allison Randal , David Hildenbrand , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 6/6] powerpc/perf: split callchain.c by bitness In-Reply-To: <20190830210645.78931423@kitsune.suse.cz> References: <567e7e876edf29ae528027d8574038fbc287f25a.1567188299.git.msuchanek@suse.de> <20190830210645.78931423@kitsune.suse.cz> Date: Mon, 02 Sep 2019 12:51:42 +1000 Message-ID: <87d0gjtnpd.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Suchánek writes: > On Fri, 30 Aug 2019 20:57:57 +0200 > Michal Suchanek wrote: > >> Building callchain.c with !COMPAT proved quite ugly with all the >> defines. Splitting out the 32bit and 64bit parts looks better. >> > > BTW the powerpc callchain.c does not match any of the patterns of PERF > CORE in MAINTAINERS (unlike callchain implementation on other > platforms). Is that intentional? No. cheers