Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Christoph Hellwig <hch@lst.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        =?iso-8859-1?Q?Thomas_Hellstr=F6m?= <thomas@shipmail.org>,
        Jerome Glisse <jglisse@redhat.com>,
        Steven Price <steven.price@arm.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Hellstrom <thellstrom@vmware.com>
Subject: Re: [PATCH 2/3] pagewalk: separate function pointers from iterator
 data
Thread-Topic: [PATCH 2/3] pagewalk: separate function pointers from iterator
 data
Thread-Index: AQHVXauzoOyMGt/Rm0+/Xu8LAWoHTqcXL4MAgAAOHoCAABCOAIAAm4cA
Date:   Mon, 2 Sep 2019 05:51:58 +0000
Message-ID: <20190902055156.GA24116@mellanox.com>
References: <20190828141955.22210-1-hch@lst.de>
 <20190828141955.22210-3-hch@lst.de> <20190901184530.GA18656@roeck-us.net>
 <20190901193601.GB5208@mellanox.com>
 <b26ac5ae-a90c-7db5-a26c-3ace2f1530c7@roeck-us.net>
In-Reply-To: <b26ac5ae-a90c-7db5-a26c-3ace2f1530c7@roeck-us.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3155ef9c-6c0b-4e99-3c89-08d72f69ab28
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB5278;
x-ms-traffictypediagnostic: VI1PR05MB5278:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <VI1PR05MB5278D5E0FCB6450E511108A5CFBE0@VI1PR05MB5278.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 01480965DA
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(199004)(189003)(11346002)(7736002)(25786009)(6436002)(478600001)(102836004)(66066001)(1076003)(64756008)(6916009)(66446008)(2906002)(99286004)(5660300002)(4326008)(33656002)(71200400001)(71190400001)(66946007)(446003)(6512007)(53936002)(66476007)(66556008)(76176011)(386003)(53546011)(6506007)(966005)(26005)(86362001)(186003)(36756003)(8676002)(6246003)(14454004)(229853002)(486006)(6306002)(6486002)(476003)(305945005)(7416002)(81166006)(81156014)(8936002)(3846002)(316002)(52116002)(54906003)(14444005)(256004)(2616005)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB5278;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: g6JO3kBvtgZxbcJjg57ba+LaBoSaZxouJ4xCd+ajdI3+nEYSorJjVj7kQ0XGBgvJiJjSU2jJrS7ZaAE01oACh08wOXzto1v7YfyzMD8JI+8kGONhzM+WXWqur+95h5+6K3e8BhlsQtweQfLpTkK8OGbykFk/fZpradsYfMdbDB8SKMzin1gsOxVgfRXcfUeWfzMnsMxQKA1p4Ks4W43piElJA3P86PGtdtCGLnXRIOeuEOxeCcvB7Pt9nsHaWfWbDrpWcQa9m2rl9aHWpGKuNMiM+1tV97SpkEbBDXURe0xpyrrShCh8Hf/CRw04mWlYhVQb+63tZ7JIAroQ14/8+VL4LOzy2SdyBZfL+e8wEbaKBbPBmyrbgzPjPy62DWAFDklC7MU4ST7odckmkecdyEBaXRMqzA+FObjyr4ccm0c=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <95F200D0B68A014B94DC2DE38EBA9207@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3155ef9c-6c0b-4e99-3c89-08d72f69ab28
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2019 05:51:58.7046
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lop4Pj6n2+1ioW7qTX/lXOF+ZFzhPKqFIA+ItWCZ7rZ9Tb4Rsh8EJ+o68pYtDaZvDkyxcqW6YQH/MQC61ip0DA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5278
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 01, 2019 at 01:35:16PM -0700, Guenter Roeck wrote:
> > I belive the macros above are missing brackets.. Can you confirm the
> > below takes care of things? I'll add a patch if so
> >=20
>=20
> Good catch. Yes, that fixes the build problem.

I added this to the hmm tree to fix it:

From 6a7e550e0f1c1eeab75e0e2c7ffe5e9e9ae649ba Mon Sep 17 00:00:00 2001
From: Jason Gunthorpe <jgg@mellanox.com>
Date: Mon, 2 Sep 2019 02:47:05 -0300
Subject: [PATCH] csky: add missing brackets in a macro for tlb.h

As an earlier patch made the macro argument more complicated, compilation
now fails with:

 In file included from mm/madvise.c:30:
 mm/madvise.c: In function 'madvise_free_single_vma':
 arch/csky/include/asm/tlb.h:11:11: error:
     invalid type argument of '->' (have 'struct mmu_gather')

Link: https://lore.kernel.org/r/20190901193601.GB5208@mellanox.com
Fixes: 923bfc561e75 ("pagewalk: separate function pointers from iterator da=
ta")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
 arch/csky/include/asm/tlb.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/csky/include/asm/tlb.h b/arch/csky/include/asm/tlb.h
index 8c7cc097666f04..fdff9b8d70c811 100644
--- a/arch/csky/include/asm/tlb.h
+++ b/arch/csky/include/asm/tlb.h
@@ -8,14 +8,14 @@
=20
 #define tlb_start_vma(tlb, vma) \
 	do { \
-		if (!tlb->fullmm) \
-			flush_cache_range(vma, vma->vm_start, vma->vm_end); \
+		if (!(tlb)->fullmm) \
+			flush_cache_range(vma, (vma)->vm_start, (vma)->vm_end); \
 	}  while (0)
=20
 #define tlb_end_vma(tlb, vma) \
 	do { \
-		if (!tlb->fullmm) \
-			flush_tlb_range(vma, vma->vm_start, vma->vm_end); \
+		if (!(tlb)->fullmm) \
+			flush_tlb_range(vma, (vma)->vm_start, (vma)->vm_end); \
 	}  while (0)
=20
 #define tlb_flush(tlb) flush_tlb_mm((tlb)->mm)
--=20
2.23.0