Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] x86/boot/compressed/64: Fix 'may be used uninitialized'
 issue
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86-ml <x86@kernel.org>
References: <1567416624-26727-1-git-send-email-zhenzhong.duan@oracle.com>
 <20190902093534.GB9605@zn.tnic>
From:   Zhenzhong Duan <zhenzhong.duan@oracle.com>
Organization: Oracle Corporation
Message-ID: <8361d582-3429-c91d-3f5a-0b988a0e16ed@oracle.com>
Date:   Mon, 2 Sep 2019 17:40:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190902093534.GB9605@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/9/2 17:35, Borislav Petkov wrote:
> On Mon, Sep 02, 2019 at 05:30:24PM +0800, Zhenzhong Duan wrote:
>> Builds kernel with "make bzImage EXTRA_CFLAGS=-Wall", gcc complains:
>>
>> arch/x86/boot/compressed/pgtable_64.c: In function 'paging_prepare':
>> arch/x86/boot/compressed/pgtable_64.c:92:7: warning: 'new' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>     new = round_down(new, PAGE_SIZE);
>>
>> In theory a random value of variable new may pass all the check and be
>> assigned to bios_start, fixing it by assigning it an initial value.
>>
>> Fixes: 0a46fff2f910 ("x86/boot/compressed/64: Fix boot on machines with broken E820 table")
>> Signed-off-by: Zhenzhong Duan<zhenzhong.duan@oracle.com>
>> Cc: Kirill A. Shutemov<kirill@shutemov.name>
>> Cc: Thomas Gleixner<tglx@linutronix.de>
>> Cc: Ingo Molnar<mingo@redhat.com>
>> Cc: Borislav Petkov<bp@alien8.de>
>> Cc: "H. Peter Anvin"<hpa@zytor.com>
>> Cc: x86-ml<x86@kernel.org>
>> ---
>>   arch/x86/boot/compressed/pgtable_64.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/boot/compressed/pgtable_64.c b/arch/x86/boot/compressed/pgtable_64.c
>> index 2faddeb..c886269 100644
>> --- a/arch/x86/boot/compressed/pgtable_64.c
>> +++ b/arch/x86/boot/compressed/pgtable_64.c
>> @@ -72,7 +72,7 @@ static unsigned long find_trampoline_placement(void)
>>   
>>   	/* Find the first usable memory region under bios_start. */
>>   	for (i = boot_params->e820_entries - 1; i >= 0; i--) {
>> -		unsigned long new;
>> +		unsigned long new = bios_start;
>>   
>>   		entry = &boot_params->e820_table[i];
>>   
>> -- 
> https://git.kernel.org/tip/c96e8483cb2da6695c8b8d0896fe7ae272a07b54
>
> In the future, use tip/master when preparing fixes because it has the
> latest state of the x86 tree and you won't have to duplicate effort,
> like in this case.

Ok, I see. Thanks for your suggestion.

Zhenzhong