Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964796AbVLUShW (ORCPT ); Wed, 21 Dec 2005 13:37:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964794AbVLUShW (ORCPT ); Wed, 21 Dec 2005 13:37:22 -0500 Received: from smtp.osdl.org ([65.172.181.4]:50136 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964796AbVLUShT (ORCPT ); Wed, 21 Dec 2005 13:37:19 -0500 Date: Wed, 21 Dec 2005 10:32:41 -0800 (PST) From: Linus Torvalds To: Takashi Iwai cc: James Courtier-Dutton , Adrian Bunk , Sergey Vlasov , Ricardo Cerqueira , mchehab@brturbo.com.br, Linux Kernel Mailing List , video4linux-list@redhat.com, perex@suse.cz, alsa-devel@alsa-project.org Subject: Re: [Alsa-devel] 2.6.15-rc6: boot failure in saa7134-alsa.c In-Reply-To: Message-ID: References: <20051220131810.GB6789@stusta.de> <20051220155216.GA19797@master.mivlgu.local> <20051220191412.GA4578@stusta.de> <43A86B20.1090104@superbug.co.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 28 On Wed, 21 Dec 2005, Takashi Iwai wrote: > > (And, interestingly, fs_initcall() is rarely used in the whole fs/ > codes! "grep -r fs_initcall linux/fs" hits only one file.) Yes. That thing was probably mis-named. It's much more commonly used for a "helper subsystem", ie things like pcmcia (that want PCI to be fully initialized and probed, but want to run before the actual device drivers start probing). > So, a "safe" solution for the time being appears to be either > - to look through the whole codes and adjust *_initcall() levels, > - to force to build saa7134-alsa as a module, or > - to move saa7134-alsa.c to sound/ directory. Well, you dropped the easiest: make saa7134 just use "late_initcall()". It's not "correct", but it's certainly no less correct than just forcing a driver to be moved for link order reasons. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/