Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp850830ybe; Mon, 2 Sep 2019 10:06:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwua0kbToTZytzMLs34cUtd0BZuPA5tfGAPMdOsaB4o6f+uAMUKxI4/WwK1aaleW7B4geHi X-Received: by 2002:a62:52d0:: with SMTP id g199mr18920866pfb.120.1567443981073; Mon, 02 Sep 2019 10:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567443981; cv=none; d=google.com; s=arc-20160816; b=RvWzl4s7jCPed6AfYnsJGk0xgO2/N6zEYCcK8IwHlB4X/fHsZ1zo69ErB3UDLvl/Ro +ymUWhYhKEiG67/eyk3i1M6b+v6YZqFA1kZLmncVFX6QorxibPqNRQlcddKuSzsnlAWa zpEGJq47yt002iArWG8EF5JgxNd/XEArlCzSXwgENUzMmeIPRud6104tWZy6naynX+Q8 H4laXbv2yEvsxRWEuv37qZvvT5euabI7wZiFY+RCdWoyKUhv/hhPG7BavRTseEwjeddu /p2ViwdXUEz8rIAt80WrLB1cu88dgUwsj5AghA6inKu+0gq3yd5GwxV0FN7Lcyy8Qz2E IeTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=fyQyIb79bl1YezWD/EXva1vuPt6ZD4xfq0dbP2NtBnc=; b=BS26a5Oq3nZ2Wt2Xf7j5Uq+7JDWK5ulh+UEQR5E2ZQwgca0Q8po5zFevjBLWKqVs6c WVm1whdw094vSw21VqlOCZXaKS1Zc1epEQbO/csnpYNt6da3zsOc9mMYYp4sOf0ItZfU uRJ8q6VFqiajQq0CIdx0JmTme7MnI72PFVPy6VyCZnJDYrGPRCX10+DV7VyzaVhk3/G8 tFPd9yZ75cXdub4a3QDkaKIniGVB1yAr2Xs2LYujAAX+zJ2yCHrLZojuJpEnC3LfoRm3 Juek7GVS/2d3HH4bBgA+io57EHaJ4I8C9IuYhBd7BmrumdEldoL/PxXS+FJDw79oPgql yqXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s10si12393446plr.43.2019.09.02.10.05.58; Mon, 02 Sep 2019 10:06:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726566AbfIBRFF (ORCPT + 99 others); Mon, 2 Sep 2019 13:05:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36796 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbfIBRFF (ORCPT ); Mon, 2 Sep 2019 13:05:05 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE181301E11C; Mon, 2 Sep 2019 17:05:04 +0000 (UTC) Received: from [10.10.122.3] (ovpn-122-3.rdu2.redhat.com [10.10.122.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F03B51001B01; Mon, 2 Sep 2019 17:05:03 +0000 (UTC) Subject: Re: [RFC PATCH 2/2] livepatch: Clear relocation targets on a module removal To: Miroslav Benes , Josh Poimboeuf Cc: Petr Mladek , jikos@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org References: <20190719122840.15353-1-mbenes@suse.cz> <20190719122840.15353-3-mbenes@suse.cz> <20190728200427.dbrojgu7hafphia7@treble> <20190814151244.5xoaxib5iya2qjco@treble> <20190816094608.3p2z73oxcoqavnm4@pathway.suse.cz> <20190822223649.ptg6e7qyvosrljqx@treble> <20190823081306.kbkm7b4deqrare2v@pathway.suse.cz> <20190826145449.wyo7avwpqyriem46@treble> From: Joe Lawrence Message-ID: <5c649320-a9bf-ae7f-5102-483bc34d219f@redhat.com> Date: Mon, 2 Sep 2019 13:05:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 02 Sep 2019 17:05:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/2/19 12:13 PM, Miroslav Benes wrote: >> I can easily foresee more problems like those in the future. Going >> forward we have to always keep track of which special sections are >> needed for which architectures. Those special sections can change over >> time, or can simply be overlooked for a given architecture. It's >> fragile. > > Indeed. It bothers me a lot. Even x86 "port" is not feature complete in > this regard (jump labels, alternatives,...) and who knows what lurks in > the corners of the other architectures we support. > > So it is in itself reason enough to do something about late module > patching. > Hi Miroslav, I was tinkering with the "blue-sky" ideas that I mentioned to Josh the other day. I dunno if you had a chance to look at what removing that code looks like, but I can continue to flesh out that idea if it looks interesting: https://github.com/joe-lawrence/linux/tree/blue-sky A full demo would require packaging up replacement .ko's with a livepatch, as well as "blacklisting" those deprecated .kos, etc. But that's all I had time to cook up last week before our holiday weekend here. Regards, -- Joe