Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 7zsmiVklgKYUqrTzMLNV3WorNr0UbxqhunFyPRuO8/qBeSONQ254imYQ7+5+FJWMpSI8xtK/z7
 3h/FuR4Prjyz9yyhKvov/wwuuoxAnfqddZ+JSviwykq2TdsdAow8Qp5OetBAJutdECPwMNcREB
 cAzO+TyjgHTg7zet0wHc6gNBreC5/5m2f5KtnDvLPBRHaqx0/BXqQPLrYLMWHnBQ2l9m70BHIK
 JC/XyZmFnNZeptv2k1g/m/Xjbr2ojleOJtMyPtU7luHIM9vKH/v57yiQ4KWui5iqraORWomxt+
 Z0A=
IronPort-PHdr: =?us-ascii?q?9a23=3AVfytWh9sSTiyTP9uRHKM819IXTAuvvDOBiVQ1K?=
 =?us-ascii?q?B42u4cTK2v8tzYMVDF4r011RmVBN+dsq0dwLOO+4nbGkU4qa6bt34DdJEeHz?=
 =?us-ascii?q?Qksu4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPER?=
 =?us-ascii?q?vjKwV1Ov71GonPhMiryuy+4ZLebxhWiDanfL9/Lgi6oQrMusUKnIBvNrs/xh?=
 =?us-ascii?q?zVr3VSZu9Y33loJVWdnxb94se/4ptu+DlOtvwi6sBNT7z0c7w3QrJEAjsmNX?=
 =?us-ascii?q?s15NDwuhnYUQSP/HocXX4InRdOHgPI8Qv1Xpb1siv9q+p9xCyXNtD4QLwoRT?=
 =?us-ascii?q?iv6bpgRQT2gykbKTE27GDXitRxjK1FphKhuwd/yJPQbI2MKfZyYr/RcdYcSG?=
 =?us-ascii?q?pEX8ZRTDdBAoK6b4sAEuEPI/9WpJTzp1sPsxS+ARSjD/7rxjJGmnP62Ks32P?=
 =?us-ascii?q?kjHw7bxgwtB9IAvmrJotv7N6kcVvu4wLXUwTjZc/9bwyvx5JTOfxs8of+MR7?=
 =?us-ascii?q?Vwcc/JxEYtFgPEj1WQqZHiPziI0ekMs2ma7+p6WuKul2Irtw98ryOyxsgwkI?=
 =?us-ascii?q?nFnJwaxU3Z9Shgxos+ON62SFZjbNK6DJddszuWOoh2T884XW1kpTo2xqcbtZ?=
 =?us-ascii?q?O/eCUG0Ikryh/bZvCdbYSF7BLuWPyPLTp5nn5oer2yihCv+ka60OL8TNO70F?=
 =?us-ascii?q?NSoypAldnDq24C2gTI6siCVvt95kCh2SuT1wzL6uFLP0Q0la3DJp4k2LEwl5?=
 =?us-ascii?q?4TvV3bHi/4hUn6laGWelgg9+Ws8ejnbbLmppiTN49wlA7yKLghmsu6AeggMw?=
 =?us-ascii?q?gOWXaU+fik2bH94UH0RK9Gg/42n6XDrpzWONgXqrSkDwJR1osv8xO/AC2n0N?=
 =?us-ascii?q?Qck3kHNlVFeBefgonpOlDOIOr3Dfajj1iwnjpm3O3GMaH7ApnXMHfMjarhca?=
 =?us-ascii?q?5n60FA0Aoz0cxf55VMB7EFIfLzXFLxtdPBAh86LQO02eDnB8t51o4FR2KPDb?=
 =?us-ascii?q?GWMLnIvV+L+O0vOe+Ma5ERuDrnLPgl/fHu3jcXg1gYKJioz5sKbzjsD+ZmKk?=
 =?us-ascii?q?TBOSHEn9wbV2oGo1xtH6TRlFSeXGsLND6JVKUm62R+V9qr?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH] extcon: axp288: Variable "val" could be uninitialized if regmap_read() fails
Date:   Mon,  2 Sep 2019 15:41:32 -0700
Message-Id: <20190902224132.20787-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function axp288_extcon_log_rsi(), variable "val" could be
uninitialized if regmap_read() fails. However, it's ued to
decide the control flow later in the if statement, which is
potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/extcon/extcon-axp288.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 7254852e6ec0..54116a926ab6 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -135,6 +135,11 @@ static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
 	int ret;
 
 	ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
+	if (ret) {
+		dev_err(info->dev, "failed to read AXP288_PS_BOOT_REASON_REG\n");
+		return;
+	}
+
 	for (i = 0, rsi = axp288_pwr_up_down_info; *rsi; rsi++, i++) {
 		if (val & BIT(i)) {
 			dev_dbg(info->dev, "%s\n", *rsi);
-- 
2.17.1