Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: uxJfzeV1h84exQyy7dUrQ4tMQTAEbilDfTh6petoqkBmvKlJKP7nYP06w/5wxeXUOqXaMYjGQj
 ff84h5W/NhRi0haGKwz7aPy4gvXlbSBsBThU3lUdjUfP9KXbjFgGsyerweZuC/JkM+K8F0RkqZ
 3pduensCkMgDAVNayKfwFEP9hfdBDf4BMiFWprqK2VYTZFmNaFyd+KXKQ0pWRF18nggDi7B2mk
 w7jGVV6Xdy5H+v3yjbxz0aMo7ukriVVuWdZ/jVwAPYs7oLI94NLDWg594Iu/+I0YIXJh6G8+f1
 DAU=
IronPort-PHdr: =?us-ascii?q?9a23=3Ahx/WFxZR21Lv1imukHENFvb/LSx+4OfEezUN45?=
 =?us-ascii?q?9isYplN5qZoMuzbnLW6fgltlLVR4KTs6sC17OM9fm/ACdaud6oizMrSNR0TR?=
 =?us-ascii?q?gLiMEbzUQLIfWuLgnFFsPsdDEwB89YVVVorDmROElRH9viNRWJ+iXhpTEdFQ?=
 =?us-ascii?q?/iOgVrO+/7BpDdj9it1+C15pbffxhEiCCybL9vMhm6txjdu8sLjYdtNKo91g?=
 =?us-ascii?q?bCr2dVdehR2W5mP0+YkQzm5se38p5j8iBQtOwk+sVdT6j0fLk2QKJBAjg+PG?=
 =?us-ascii?q?87+MPktR/YTQuS/XQcSXkZkgBJAwfe8h73WIr6vzbguep83CmaOtD2TawxVD?=
 =?us-ascii?q?+/4apnVAPkhSEaPDMi7mrZltJ/g75aoBK5phxw3YjUYJ2ONPFjeq/RZM4WSX?=
 =?us-ascii?q?ZdUspUUSFBB4K8b5AUD+oAO+ZYoJT2qUUXoxCjCwmsBf3gyjtViXTr2aE33f?=
 =?us-ascii?q?gtHQTA0Qc9HdwBrW7Uoc36O6ccU++7zKfGwzbeYfxKwjr99JTEfwo9rf2QQb?=
 =?us-ascii?q?59c8zcwlQvGQPfiVWQrJToMDGU1uUMs2ib8u1gXv+shG4nsQ5xoyWky8Asi4?=
 =?us-ascii?q?jIhoIa0FHE+TllzIs7PtC4VVJ0YcS+HJROqi6aKpJ7T8U/SG9roCY30qMKtY?=
 =?us-ascii?q?K/cSQQy5kqxwTTZ+GGfoWK+B7uVvudLDFlj3x/Yr2/nQy98U24x+35Ucm7zU?=
 =?us-ascii?q?hFozJektnJqnANzxvT6tWbSvdl/keuxzKP1wfL5+FBO080lK7bJ4clwr4+i5?=
 =?us-ascii?q?YfqErDEy3rlEnsg6+WcUIk+ues6+v5eLnpupicN4pshgH/NKQhhNC/DPwmPg?=
 =?us-ascii?q?QSW2WX4+ex2b358UHkQbhHjOc6n6vEvJzCIMQUvK+5Awtb0oY57Ba/Ci+r0d?=
 =?us-ascii?q?QZnHkHNl1FeQ6Lg5TnNlzVPfD3Ee2/j06ynzh22vDKJqfhDYnVLnjfjLfheq?=
 =?us-ascii?q?5w60pdyAo10NBe6ItYCrIfL/LpXE/+qtjYAwQnMwy73ennEs9x1oAAVmKVBK?=
 =?us-ascii?q?+WLqfSvUWP5uI1LOnfLKEPvzOoGvk35+PpxU05kF5VKbi73ZIWMCjjNultOQ?=
 =?us-ascii?q?OUbWe60YRJKnsDogdrFL+is1aFSzMGIinqUg=3D=3D?=
MIME-Version: 1.0
References: <20190902231510.21374-1-yzhai003@ucr.edu>
In-Reply-To: <20190902231510.21374-1-yzhai003@ucr.edu>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Mon, 2 Sep 2019 16:22:03 -0700
Message-ID: <CABvMjLSeQjMi0DPLGH3qnoLNb=gc+P_4ZF7OQQMHa6uRMD42Dg@mail.gmail.com>
Subject: Re: [PATCH] net: hisilicon: Variable "reg_value" in function
 mdio_sc_cfg_reg_write() could be uninitialized
Cc:     Chengyu Song <csong@cs.ucr.edu>, Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry for the inconvenience. I made some mistake here, please ignore
this patch and I will submit a new one.

On Mon, Sep 2, 2019 at 4:14 PM Yizhuo <yzhai003@ucr.edu> wrote:
>
> In function mdio_sc_cfg_reg_write(), variable reg_value could be
> uninitialized if regmap_read() fails. However, this variable is
> used later in the if statement, which is potentially unsafe.
>
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
> ---
>  drivers/net/ethernet/hisilicon/hns_mdio.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
> index 3e863a71c513..f5b64cb2d0f6 100644
> --- a/drivers/net/ethernet/hisilicon/hns_mdio.c
> +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c
> @@ -148,11 +148,17 @@ static int mdio_sc_cfg_reg_write(struct hns_mdio_device *mdio_dev,
>  {
>         u32 time_cnt;
>         u32 reg_value;
> +       int ret;
>
>         regmap_write(mdio_dev->subctrl_vbase, cfg_reg, set_val);
>
>         for (time_cnt = MDIO_TIMEOUT; time_cnt; time_cnt--) {
> -               regmap_read(mdio_dev->subctrl_vbase, st_reg, &reg_value);
> +               ret = regmap_read(mdio_dev->subctrl_vbase, st_reg, &reg_value);
> +               if (ret) {
> +                       dev_err(mdio_dev->regmap->dev, "Fail to read from the register\n");
> +                       return ret;
> +               }
> +
>                 reg_value &= st_msk;
>                 if ((!!check_st) == (!!reg_value))
>                         break;
> --
> 2.17.1
>


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside