Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: iDRoxpWPE5/MSqP19njuzSqOin+TWOrYrFwWrCYNBDPUyDdKifS7c6WbFUHfiE3LW6+4vEllHC
 0pn89nnc4cEXj+RblJe7lnQFQx6nXuvJ8eOtAG3ks6IHaOFl31m2Ix58tcPI1wClkI0bBCSsG3
 CtRPidBz8jG4W9C3WQ0WqIXSHBczY5X/wPFE0zbyp6E/p6FYL0lB/GvdQqD2nKAQyQOzauntq4
 5zR8tyvJWlvJRPKTE+LYXlu0ESt+vJkYIFmv3P+uhrK4Olk7XHkTYYAMkb+1xvFTCjh1+9b+a9
 HOs=
IronPort-PHdr: =?us-ascii?q?9a23=3AVLTmaByMP4ygix/XCy+O+j09IxM/srCxBDY+r6?=
 =?us-ascii?q?Qd2+gVIJqq85mqBkHD//Il1AaPAdyBrasb0qGM6+jJYi8p2d65qncMcZhBBV?=
 =?us-ascii?q?cuqP49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx?=
 =?us-ascii?q?7xKRR6JvjvGo7Vks+7y/2+94fcbglVmjaxe65+IReroQneqMUanZZpJ7osxB?=
 =?us-ascii?q?fOvnZGYfldy3lyJVKUkRb858Ow84Bm/i9Npf8v9NNOXLvjcaggQrNWEDopM2?=
 =?us-ascii?q?Yu5M32rhbDVheA5mEdUmoNjBVFBRXO4QzgUZfwtiv6sfd92DWfMMbrQ704RS?=
 =?us-ascii?q?iu4qF2QxLzliwJKyA2/33WisxojaJUvhShpwBkw4XJZI2ZLedycr/Bcd8fQ2?=
 =?us-ascii?q?dKQ8RfWDFbAo6kYIQPAegOM+ZWoYf+ulUAswexCBKwBO/z0DJEmmP60bE43u?=
 =?us-ascii?q?knDArI3BYgH9ULsHnMrtr1NaYTUeCozKnP0D7MbPNW1i386IPVdR0gofCNXb?=
 =?us-ascii?q?JqfsrQ1UUjCw3Ig06NqYP5JTOZzPoCvHWG7+d5U++klmApqwZ0oje1x8csjJ?=
 =?us-ascii?q?HEhoELxVDe8yV23oI1Kce/SE5hbt6pFoZbuSKCN4ZuXM8uX2VltDw5x7AGo5?=
 =?us-ascii?q?K3YSkHxZY9yxPdd/CKdZWD7Aj5W+aLOzh4gWpoeLe4hxmv70et0vb8Vsyo0F?=
 =?us-ascii?q?ZSqSpFj8XMumgN1xPN7siHTeNw/kK71jaO0wDf8+VEIU4pmabCJZ4swKI8mo?=
 =?us-ascii?q?AcsUTEGS/2l0H2g7GMeko4/eio7vzrYrTgppCCK495kh/yPrgql8ClAuk1Mh?=
 =?us-ascii?q?ICU3Wa9Om+zrHu/1H1TK1PjvIsk6nZtJ7aJd4cpq68GwJU0oci6xalADenzN?=
 =?us-ascii?q?gUgXcKIUlYeB2blYjlIU/BL+3lDfunmVSjjC9rx+zaPr3mGpjNKnnDkLH8fb?=
 =?us-ascii?q?dy8kJcyxQ8zcpZ551KDrEMO+zzWkDvu9zCFBM5MBK7w/zhCNpj0oMSQ2WPAr?=
 =?us-ascii?q?WWMPCajVjdz+QjMqG3ZIILszbwLfsir6rni3Mo30QdcLei3ZYRa3eQEfFvIk?=
 =?us-ascii?q?Hfan3p1IQvC2AP6zs/Xuz3jxWwUTdSLyKjTaI152ljU6q7Bp2FS4yw1u/SlB?=
 =?us-ascii?q?ynF4FbMzgVQmuHFm3lIsDdA68B?=
MIME-Version: 1.0
References: <20190902224132.20787-1-yzhai003@ucr.edu> <CAHp75VcWA22y2Diinp9rnq1GGR_YFHvaunYCS3eAVcrAuccP8Q@mail.gmail.com>
In-Reply-To: <CAHp75VcWA22y2Diinp9rnq1GGR_YFHvaunYCS3eAVcrAuccP8Q@mail.gmail.com>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Mon, 2 Sep 2019 16:23:35 -0700
Message-ID: <CABvMjLTJNBZgfuPY9XxhZepuD1gpZM87RKsLh3YVvZd5165LSA@mail.gmail.com>
Subject: Re: [PATCH] extcon: axp288: Variable "val" could be uninitialized if
 regmap_read() fails
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     "csong@cs.ucr.edu" <csong@cs.ucr.edu>,
        "zhiyunq@cs.ucr.edu" <zhiyunq@cs.ucr.edu>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Hans de Goede <hdegoede@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks Andy, sorry for the inconvenience, I will check the log more
carefully next time.

On Mon, Sep 2, 2019 at 3:48 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
>
>
> On Tuesday, September 3, 2019, Yizhuo <yzhai003@ucr.edu> wrote:
>>
>> In function axp288_extcon_log_rsi(), variable "val" could be
>> uninitialized if regmap_read() fails. However, it's ued to
>> decide the control flow later in the if statement, which is
>> potentially unsafe.
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=d72e3dc7915fc6c54645772c13f4afc0e676c7e2
>
>>
>> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
>> ---
>>  drivers/extcon/extcon-axp288.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
>> index 7254852e6ec0..54116a926ab6 100644
>> --- a/drivers/extcon/extcon-axp288.c
>> +++ b/drivers/extcon/extcon-axp288.c
>> @@ -135,6 +135,11 @@ static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
>>         int ret;
>>
>>         ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
>> +       if (ret) {
>> +               dev_err(info->dev, "failed to read AXP288_PS_BOOT_REASON_REG\n");
>> +               return;
>> +       }
>> +
>>         for (i = 0, rsi = axp288_pwr_up_down_info; *rsi; rsi++, i++) {
>>                 if (val & BIT(i)) {
>>                         dev_dbg(info->dev, "%s\n", *rsi);
>> --
>> 2.17.1
>>
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside