Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1369905ybe; Mon, 2 Sep 2019 20:01:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTh86Nx3jxlMu0e8UvQVGBDvMDnBR49VNBhpgt0fStVgjn34JHJvF/6/2wJ+Q/E9HxEhrm X-Received: by 2002:a17:902:2bc7:: with SMTP id l65mr31329122plb.119.1567479702759; Mon, 02 Sep 2019 20:01:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567479702; cv=none; d=google.com; s=arc-20160816; b=WAIDLaEJ3bCH2FpKP1Tjd7zqcDO+RzR5/WLgjLj2sL6q+BD/O9dvDW5o2XoEJ+nEME dWuo5LyPdmV71yZmMpN1V2CA/TTONyiNuqTp3HZRH1FVi/UuyBg3t/ufGdkxsmzPOAjf pXd9QjLP8pAGT599+9ftHKenWAWgs7Nz0JQ6Ea7ixybwFxYpsTRonuxXqhkvyEuqYFD8 BzNoDOP3mynTtfOiRrGZY6fHOj/QnPyKrCeO8c8JT3vsQt6pCplrJ/GJLOdNxCSh2aOW XU/MKhC6XWMgqbFkkHoDCnBjdhtqulC3wfzVvF/ZCB8fxBhdTk/n7EdbQRJm+dmwt6Fq jOtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=jsLTABL54cbJhRHow9JRsxMNnW1u1Kx0ymUXkvgy7Z8=; b=dlR0rhIEyz67w7ZeyBU6DbG5x7gSWwSxbCTubpwR5VhiXjSb6T8kqrrblr99ndFO01 3X0rsMpyBLL9hizVrBmyzMf8cforfidOlusEeKMvhGJBatkEz+vyJx062g8tJcBpF+vi dDgdczpYCIh124ZZpo74r4JmC8zXyXTeyBxN+3cX9QLa08FzYP51Vja2yUaMksA7BeR2 PXplyyTE5mxGKBdiqqqzTlDiDt/+by7HqWXqf0G+s+7SWUCGTNc7dAZfdwSFBRnJUyOT EMjvnxegYieokqH4yLWCUEvtsyCLqra1VAJxEz9Sfz7wNJQYibeTsmv0jxDQ60uSnt6w 1pug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1si13052547pgg.490.2019.09.02.20.01.23; Mon, 02 Sep 2019 20:01:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726779AbfICDAc convert rfc822-to-8bit (ORCPT + 99 others); Mon, 2 Sep 2019 23:00:32 -0400 Received: from mga07.intel.com ([134.134.136.100]:9424 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfICDAb (ORCPT ); Mon, 2 Sep 2019 23:00:31 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 20:00:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,461,1559545200"; d="scan'208";a="357606549" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by orsmga005.jf.intel.com with ESMTP; 02 Sep 2019 20:00:30 -0700 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 11:00:28 +0800 Received: from pgsmsx102.gar.corp.intel.com ([169.254.6.48]) by PGSMSX109.gar.corp.intel.com ([169.254.14.101]) with mapi id 14.03.0439.000; Tue, 3 Sep 2019 11:00:29 +0800 From: "Pan, Harry" To: Peter Zijlstra CC: LKML , "x86@kernel.org" Subject: RE: [PATCH] perf/x86/intel: Update ICL Core and Package C-state event counters Thread-Topic: [PATCH] perf/x86/intel: Update ICL Core and Package C-state event counters Thread-Index: AQHVQ5PIUsijJvZMx0u0Sspcp/PXuqcTQD8AgAY/qEY= Date: Tue, 3 Sep 2019 03:00:28 +0000 Message-ID: <6089B7674E6F464F847AB76B599E0EAA789D44BE@PGSMSX102.gar.corp.intel.com> References: <20190726090846.6109-1-harry.pan@intel.com>,<20190830113334.GF2369@hirez.programming.kicks-ass.net> In-Reply-To: <20190830113334.GF2369@hirez.programming.kicks-ass.net> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.19.9.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you Peter for pointing out my miss, I appreciate that sincerely. > * MSR_CORE_C3_RESIDENCY: CORE C3 Residency Counter > * perf code: 0x01 > * Available model: NHM,WSM,SNB,IVB,HSW,BDW,SKL,GLM, > - CNL > + CNL,ICL That has a missing * introduced by the last such patch. Please take this opportunity to put it back in.