Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190902100054.6941-1-jian-hong@endlessm.com> <s5hwoerx6wf.wl-tiwai@suse.de>
In-Reply-To: <s5hwoerx6wf.wl-tiwai@suse.de>
From:   Jian-Hong Pan <jian-hong@endlessm.com>
Date:   Tue, 3 Sep 2019 13:30:04 +0800
Message-ID: <CAPpJ_edbfN_6yfxjBSV5dnp40ufCeWeMiF_QdsPmWmHubagCQw@mail.gmail.com>
Subject: Re: [PATCH] ALSA: hda/realtek - Enable internal speaker & headset mic
 of ASUS UX431FL
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        Linux Upstreaming Team <linux@endlessm.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Takashi Iwai <tiwai@suse.de> =E6=96=BC 2019=E5=B9=B49=E6=9C=882=E6=97=A5 =
=E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=887:41=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Mon, 02 Sep 2019 12:00:56 +0200,
> Jian-Hong Pan wrote:
> >
> > Original pin node values of ASUS UX431FL with ALC294:
> >
> > 0x12 0xb7a60140
> > 0x13 0x40000000
> > 0x14 0x90170110
> > 0x15 0x411111f0
> > 0x16 0x411111f0
> > 0x17 0x90170111
> > 0x18 0x411111f0
> > 0x19 0x411111f0
> > 0x1a 0x411111f0
> > 0x1b 0x411111f0
> > 0x1d 0x4066852d
> > 0x1e 0x411111f0
> > 0x1f 0x411111f0
> > 0x21 0x04211020
> >
> > 1. Has duplicated internal speakers (0x14 & 0x17) which makes the outpu=
t
> >    route become confused. So, the output volume cannot be changed by
> >    setting.
> > 2. Misses the headset mic pin node.
> >
> > This patch disables the confusing speaker (NID 0x14) and enables the
> > headset mic (NID 0x19).
>
> Is 0x14 really a dead pin?  Or is a surround/bass speaker or such?

I checked Windows (updated to latest and including Realtek MEDIA) on
ASUS UX431FL laptop again.  Although it has two internal speaker pins,
there is only one set of internal speaker including left/right
channels.  And the audio test (Speaker Setup) only shows left/right
channels.  So, NID 0x14 can be disabled.

Jain-Hong Pan

> >
> > Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> > ---
> >  sound/pci/hda/patch_realtek.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realte=
k.c
> > index e333b3e30e31..0a1fa99a6723 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5797,6 +5797,7 @@ enum {
> >       ALC286_FIXUP_ACER_AIO_HEADSET_MIC,
> >       ALC256_FIXUP_ASUS_MIC_NO_PRESENCE,
> >       ALC299_FIXUP_PREDATOR_SPK,
> > +     ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC,
> >  };
> >
> >  static const struct hda_fixup alc269_fixups[] =3D {
> > @@ -6837,6 +6838,16 @@ static const struct hda_fixup alc269_fixups[] =
=3D {
> >                       { }
> >               }
> >       },
> > +     [ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC] =3D {
> > +             .type =3D HDA_FIXUP_PINS,
> > +             .v.pins =3D (const struct hda_pintbl[]) {
> > +                     { 0x14, 0x411111f0 }, /* disable confusing intern=
al speaker */
> > +                     { 0x19, 0x04a11150 }, /* use as headset mic, with=
out its own jack detect */
> > +                     { }
> > +             },
> > +             .chained =3D true,
> > +             .chain_id =3D ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
> > +     },
> >  };
> >
> >  static const struct snd_pci_quirk alc269_fixup_tbl[] =3D {
> > @@ -6995,6 +7006,7 @@ static const struct snd_pci_quirk alc269_fixup_tb=
l[] =3D {
> >       SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXU=
P_ASUS_ZENBOOK),
> >       SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXU=
P_ASUS_ZENBOOK_UX31A),
> >       SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DM=
IC),
> > +     SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_I=
NTSPK_HEADSET_MIC),
> >       SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73=
JW),
> >       SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MI=
C),
> >       SND_PCI_QUIRK(0x1043, 0x1b13, "Asus U41SV", ALC269_FIXUP_INV_DMIC=
),
> > --
> > 2.20.1
> >
> >