Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 03 Sep 2019 07:53:06 +0200
Message-ID: <s5hy2z6hqnx.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jian-Hong Pan <jian-hong@endlessm.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        Linux Upstreaming Team <linux@endlessm.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda/realtek - Enable internal speaker & headset mic of ASUS UX431FL
In-Reply-To: <CAPpJ_edbfN_6yfxjBSV5dnp40ufCeWeMiF_QdsPmWmHubagCQw@mail.gmail.com>
References: <20190902100054.6941-1-jian-hong@endlessm.com>
        <s5hwoerx6wf.wl-tiwai@suse.de>
        <CAPpJ_edbfN_6yfxjBSV5dnp40ufCeWeMiF_QdsPmWmHubagCQw@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 03 Sep 2019 07:30:04 +0200,
Jian-Hong Pan wrote:
> 
> Takashi Iwai <tiwai@suse.de> 於 2019年9月2日 週一 下午7:41寫道：
> >
> > On Mon, 02 Sep 2019 12:00:56 +0200,
> > Jian-Hong Pan wrote:
> > >
> > > Original pin node values of ASUS UX431FL with ALC294:
> > >
> > > 0x12 0xb7a60140
> > > 0x13 0x40000000
> > > 0x14 0x90170110
> > > 0x15 0x411111f0
> > > 0x16 0x411111f0
> > > 0x17 0x90170111
> > > 0x18 0x411111f0
> > > 0x19 0x411111f0
> > > 0x1a 0x411111f0
> > > 0x1b 0x411111f0
> > > 0x1d 0x4066852d
> > > 0x1e 0x411111f0
> > > 0x1f 0x411111f0
> > > 0x21 0x04211020
> > >
> > > 1. Has duplicated internal speakers (0x14 & 0x17) which makes the output
> > >    route become confused. So, the output volume cannot be changed by
> > >    setting.
> > > 2. Misses the headset mic pin node.
> > >
> > > This patch disables the confusing speaker (NID 0x14) and enables the
> > > headset mic (NID 0x19).
> >
> > Is 0x14 really a dead pin?  Or is a surround/bass speaker or such?
> 
> I checked Windows (updated to latest and including Realtek MEDIA) on
> ASUS UX431FL laptop again.  Although it has two internal speaker pins,
> there is only one set of internal speaker including left/right
> channels.  And the audio test (Speaker Setup) only shows left/right
> channels.  So, NID 0x14 can be disabled.

OK, thanks for clarification.
I applied the patch now.


Takashi