Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Sep 2019 12:11:38 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Katsuhiro Suzuki <katsuhiro@katsuster.net>
Cc:     David Yang <yangxiaohua@everest-semi.com>,
        Daniel Drake <drake@endlessm.com>,
        Hans de Goede <hdegoede@redhat.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing
Message-ID: <20190903111138.GA6247@sirena.co.uk>
References: <20190831162650.19822-1-katsuhiro@katsuster.net>
 <20190902120248.GA5819@sirena.co.uk>
 <1a3c5934-4731-d474-e9d5-795e8337b180@katsuster.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4"
Content-Disposition: inline
In-Reply-To: <1a3c5934-4731-d474-e9d5-795e8337b180@katsuster.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--YiEDa0DAkWCtVeE4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 03, 2019 at 04:19:10AM +0900, Katsuhiro Suzuki wrote:
> On 2019/09/02 21:02, Mark Brown wrote:

> > The best way to handle this is to try to support both fixed and variable
> > clock rates, some other drivers do this by setting constraints based on
> > MCLK only if the MCLK has been set to a non-zero value.  They have the
> > machine drivers reset the clock rate to 0 when it goes idle so that no
> > constraints are applied then.  This means that if the machine has a

> In my understanding, fixed and variable clock both use set_sysclk() for
> telling their MCLK to codec driver. For fixed MCLK cases we need to
> apply constraint but for variable MCLK cases we should not set
> constraints at set_sysclk(). How can we identify these two cases...?

Like I say it's usually done by settingthe MCLK to 0 when not in use and
then not applying any constraints if there's no MCLK set.

--YiEDa0DAkWCtVeE4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1uSmcACgkQJNaLcl1U
h9BHBwf/URm9L7YnJCv+tUQB+bbOzUTiUQOR23hSvxTvO+aMMjXRaNFKTTj+1ZV4
h876xX+RykF8GgLvEOKMdkcmbk0UHdpj350OOLBI/8LQ3Ir/FhSHk1FVV4KM+n2V
hYBfz48cTj39UvNutOrZu7YdAG2zT3e6zgtIH3qMNj+E0CP2Xr+5qggA6QPo3d44
erXRwSRS94Og2G1bKm+Zm9wF7w/JJA766ige3ROWWgpZ+TF/QkZIlv2wczUha1U3
qFcgjJymaUV2D7RAF7R1MqlvAFSc9gqommoGhN3SebKsDt1lF2zH0sFkAqjQ1LDg
V1ET11vnqFz1nqWhMYfbcR4i1A3ofw==
=2Fmo
-----END PGP SIGNATURE-----

--YiEDa0DAkWCtVeE4--