Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a
 single monolithic driver
To:     Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc:     linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        mchehab@kernel.org, helen.koike@collabora.com, hverkuil@xs4all.nl,
        laurent.pinchart@ideasonboard.com, andrealmeid@collabora.com,
        dafna3 <dafna3@gmail.com>, Shuah Khan <skhan@linuxfoundation.org>
References: <cover.1566334362.git.skhan@linuxfoundation.org>
 <a7b877c08d0885fe7e8bffc9b24ef0a2d6236147.1566334363.git.skhan@linuxfoundation.org>
 <09c3ddad7122efb23201dff6e11aaf7455c748ea.camel@collabora.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <76c8489f-4c6f-27df-ce28-a7ce3e8b3843@linuxfoundation.org>
Date:   Tue, 3 Sep 2019 06:55:21 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <09c3ddad7122efb23201dff6e11aaf7455c748ea.camel@collabora.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/3/19 6:50 AM, Dafna Hirschfeld wrote:
> Hi,
> Thank you for working on the patchset.
> 
> Since there is only one module now, the section in the vimc Documentation
> regarding module params should be changed:
> 
> In the file Documentation/media/v4l-drivers/vimc.rst
> The following text should be removed:
> 
> ```
> You should pass
> those arguments to each subdevice, not to the vimc module. For example::
> 
>          vimc_subdevice.param=value
> ```
> 
> (no inline comments)
> 

Thanks Dafna. Yes Documentation needs updates for other reasons and
the module params is on my list as well to fix.

thanks,
-- Shuah