Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1977132ybe; Tue, 3 Sep 2019 06:21:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzuP4hNH3blV8K0CokNXQGaz7zHtoh9gFXcd5Jy9s0Tx5lUFsDJTZQFFN2TJwU24jQMVhF X-Received: by 2002:aa7:9a86:: with SMTP id w6mr39891256pfi.60.1567516916908; Tue, 03 Sep 2019 06:21:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567516916; cv=none; d=google.com; s=arc-20160816; b=SCPtEy4R7kQvy0jCAtHJbJ6Yy3Jjhnlw/MXbudCLQXzTurqYK8tRCry+6FVF5l0yt4 oX4EJ2k98qytLwsF6jSUkf+CLujyDMvuZgGTV1qzCccI7gYXMkyc8HFN784CYrOdtZsy 7vuHbho9AnranMtYKQBWT2U00kVSZVHRB7iyr452cSXFV40+mvDM4NCg5F8/IvoyooYe 9dwIdjyUCUsn+EUpNA3wdEbNoDz60j+z52sl2O3/OleLJbvYgrpKOPzfXNG3qZ4C4zIG 15J+Vl7qUF31q6u/EK7WkM40RsoPQBFSpHq8vuwHUsEJZt9D2z++zEhxEGk3UpoyNFr9 Cw9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:autocrypt :subject:from:cc:to:dkim-signature; bh=7k+mUo8jjzBkvgw15+qvhZ1LW91iVyymcDfQn5vuFQA=; b=EQ0fIA6MNo8slhiLiEAdzapsZSLGuVUy/xfKZQeLbW/SpI9ZX73bagQOQJAVWZnQxD 0bHdbmAU2UspdhNFnRTqbpPMJ8qFCLCZeeGQDeBw1ykHoqB3dBUsfe+PL3OtO71AMBPg ZsmmwEIkzUcsRw9DXsGFZCpZl2+GsrEhIEPQGHwx/KLlGxUxKPPSwG7czwp81GSz4v1k S3MYNBaWUUSIQdxNOPDkDbdvFaoIJhu7PVF+61tL5Hm7N4nOH4/Ni74GE/w8GtKDPbkS TnetbQLcFzg8tvdSVVEEsnDgEuvDsjTEFPJ2KnV4DOzhB0sLKjvlVneh6YmknrYV5+yf YVCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=p5seTyJF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q67si325970pjq.42.2019.09.03.06.21.40; Tue, 03 Sep 2019 06:21:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=p5seTyJF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729247AbfICNUt (ORCPT + 99 others); Tue, 3 Sep 2019 09:20:49 -0400 Received: from mout.web.de ([212.227.17.12]:52125 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727005AbfICNUs (ORCPT ); Tue, 3 Sep 2019 09:20:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1567516843; bh=8p6F/11SX6cVpViLiKvZcfvZTKjngOdYepqGz4ztNyg=; h=X-UI-Sender-Class:To:Cc:From:Subject:Date; b=p5seTyJFOtpIJJHnrG3yU7LAaVnrr1A1ePV70hLqP9B2CgAQ1dSoVE1GkqdlcLDfD KM9rjzoYVPfEMWUCrCU1nufOdQ+V75OlxTOxug/77k+TM730xKksfAeiC7B3XirVDi WfILzeL2FPXnnktNeUlgIEjfamlfx9Xrw72NquZk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.133.133.43]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LwHp4-1iEXRN2Tq2-017zUp; Tue, 03 Sep 2019 15:20:43 +0200 To: cluster-devel@redhat.com, Andreas Gruenbacher , Bob Peterson Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Subject: [PATCH] gfs2: Delete an unnecessary check before brelse() Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <9250af4a-993c-e86e-678c-acbd59b0861a@web.de> Date: Tue, 3 Sep 2019 15:20:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:H8D1Icc6wOGUh2N+mEArqb852oKgmy9ZhFqtO+iN9G7y84+v3tN /9q0T12/YyxLpHP+XOrKgtO0nCZjHkf8maDBqLgIrNBsddx2m+/pV6Xjoy7K2dEkJmF92uC KLoLO3IMFyTqbih2Z9Y2CKMxmVzjy5aDVWv6FJu/z4AGNotOsQE1G69T4HBlwkwbmhfgNZr eoNeEObrAymYXJKcNyBAA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:QOIo4FmgA2o=:1OKt0qssUyNo2MmYUifZqK Xf45SbUQj8Sh6uvR64eEwDalTgOB/EQg5nnkMQLmS/5xLD1RjjviH/4H8IeAXeat+dcUz94jw ZJkCSCWwvewRt8CGPM75Q1Vwbx2xRKba+SvYJhyiwvAq08b/VelsCb+ghL+HbICJFcYaxFdTM bt84liaPZpPiwIvptQuomsTgb26WuVDnU5WpEHv3gAR2XBJF+WsvRJILMG+ohJYnNRZNn8YPd acqHZyQP5KbsnJRxtTWqPl3FbmzdPzbTUT4vEGcDa5Nuzl2c4/i84JUla6DTZ0N6sM0qTj7nC tPAB2eeVuIVSEHTOqhMkaubaJINOs4iT0SrJhP0wRVtBExlOi1UoUYu2JbmQ+i894K3t1XCdh XwARn1O6fwr13qNEyyDN25D5Czma2HixCJkHkrvuWfr+lrt82zxzfhv77/bF2+Zw2b5cHae77 GGMVEzpWOJDaKl6REd3tDGHfe7LfgAzD8BzE0qhAUCX+KtSNuMeQ9tqExmSkyUnRla8gITRQx ZSkDjIjwCekPTA26HgVQ9rE+YrvXkc1Sx+IPQ890z3r5y0Lg8y0HOf8FK12Kq19komhhQIvot dIgAE/ae8iNhkeaTxCgFlO302AkQX2viBU2c8MphS1f1SeB9frhUJyP32FJedTMC6CsHdItzM wNyNpC5vk25QLDmAOVmf7VtQ85uMOVWyTNjum38TPiSwsC+8QEOWMn7L0Rawn+ojMeofKWzEc iQqwZ/lKB5N4adxwYxMkA/f/M70idG55EdGp4NsLUx442kOTnlT4Fg/uUxQ7en5EzCRbWtbzj KtO9somub2rJp80VVWhd0nOECsWJwngZNmDyQLhnAKD47dyaVCdAYmBDz8nfhaer+jW57h4vE 3CkgOJAVnDHubS1MU3wsD1LA/XKqoRtO+ZpqwlRrcF6QToZyfs03yrwtTorVzEy9ar6WvYI6+ isKr7H+yswChHb1wep7YOf834da3e0Ap4Dqv6/wCFrH3KN6HOo3fxigBKLg3YjI+iGFSCEVP6 QncPF6bosHFGrK5uEGWZx0k/3BLyo6DOzDS81+fmoW2p9Rp/AKLI8G2e40w1O8Hzvr1M6y1PK NHdA0BCugvr+OLmn/dUUARrLlf9a5pl6+ACZm4KVnQofz99vngemPDxw/KochRYTR6enImZ2e UPmRGvn1Ob78Omg9QYCzeG0qzPE9cI/pUeZbgvlGVwM9rw6A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 3 Sep 2019 15:10:05 +0200 The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring =2D-- fs/gfs2/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 6f35d19eec25..eb9c0578978f 100644 =2D-- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -1463,8 +1463,7 @@ static int gfs2_dir_read_leaf(struct inode *inode, s= truct dir_context *ctx, sort_offset : entries, copied); out_free: for(i =3D 0; i < leaf; i++) - if (larr[i]) - brelse(larr[i]); + brelse(larr[i]); kvfree(larr); out: return error; =2D- 2.23.0