Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2074849ybe; Tue, 3 Sep 2019 07:39:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqxMXKL2YdWNh7wiFLeNmef3YLxutBF8VaBYRluybW32GuZGCpcxgdT+/v8XbIpI10KHYX45 X-Received: by 2002:a17:902:b605:: with SMTP id b5mr6530984pls.103.1567521551395; Tue, 03 Sep 2019 07:39:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567521551; cv=none; d=google.com; s=arc-20160816; b=NMVvP3BDp2PVPdTUvBerU5SsuT0/LsT/4Sr3s6W0Axj8cAm8wUAWvXvViuyskIKCWA V6suluqjBYyg/i51VIwaatMCUg3woIRAq0edwq4WCnB5g36y52FFTezaCWzfCu5eYYZo 5vhqgTxa9byJFnaHXFvywBL2llc/S8pKRK+FQjRjLskfVTjFbFNztes6OhKjYj/396uI kBUf1459dISZSshYorfOzHxJYgI3Q7rWFz5P3DRoZD5+kRXwVrLA806sml6AN7n8RHqJ faoGd2ssj2brwWYSIpFbo/wxLJTmqTucH5smJXlYyMByIuDfmibSLK1UUp8eZYEB6697 3fHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JwoHorLDj3YrgsVG/gtMgRwAxedXcm+SKw+JuhjQ67I=; b=SqQS8Emgk2rTN78Ke3eA4V7rKt7HvLCmxxZyzplxCFrDBNl7OMcw/2EecvWPbe0d5g 73CBErS1Qf+ZVhsCdiX7A3fplCKt1na/d3zsnQQcC4nQjPiUgVTi/T+Eje39OzFYoIbW 78eNAZU1zcEE3mwTNxjMYc6+TRHaFDwCls0doWg0p9N0BDWl3jozrVT56yBCWoTdgLkR LWdbuIU9LNMve5ZVWGGOvKfMxx389KvxCQJuOzmEmfETqeZuvDAwMbggNOkfgjE9ISJt mkp83cjOZodBox0ONbHhUwCP8nZVTn3zWKeN6K9kQBPG2dZ1GM25RdhjT4NEjrWzk9kV FNKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OJb3Kho2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o61si15657016pld.132.2019.09.03.07.38.55; Tue, 03 Sep 2019 07:39:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OJb3Kho2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729473AbfICOiH (ORCPT + 99 others); Tue, 3 Sep 2019 10:38:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:35936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfICOiH (ORCPT ); Tue, 3 Sep 2019 10:38:07 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E0D520828; Tue, 3 Sep 2019 14:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567521486; bh=NYvh1Ty2TcysP6q9uoPqBfVZ4o8Dsna8O9GWcNeTjPM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OJb3Kho20mdnwL0J0X12EPvZi+YCveo7/1MvWOJty8arm52+WGvg72faQoeDkDslp gcXbCoUgsYIImpD8m9W/cZZXzmw/u/1Ai/IOtMCjmud5lXAkRUAZliTRZJFjfkXUvV F/jRoBkgB+zfTcpRpoe3lmbufzbFVwL5ziqsj2V4= Date: Tue, 3 Sep 2019 15:38:01 +0100 From: Will Deacon To: Vincenzo Frascino Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, catalin.marinas@arm.com, 0x7f454c46@gmail.com, salyzyn@android.com, paul.burton@mips.com, luto@kernel.org, tglx@linutronix.de Subject: Re: [PATCH v2 1/8] arm64: compat: vdso: Expose BUILD_VDSO32 Message-ID: <20190903143800.k6r663abs2g2ddpg@willie-the-truck> References: <20190830135902.20861-1-vincenzo.frascino@arm.com> <20190830135902.20861-2-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 03:36:16PM +0100, Vincenzo Frascino wrote: > On 8/30/19 2:58 PM, Vincenzo Frascino wrote: > > clock_gettime32 and clock_getres_time32 should be compiled only with the > > 32 bit vdso library. > > > > Expose BUILD_VDSO32 when arm64 compat is compiled, to provide an > > indication to the generic library to include these symbols. > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Signed-off-by: Vincenzo Frascino > > Acked-by: Catalin Marinas > > --- > > arch/arm64/include/asm/vdso/compat_gettimeofday.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/include/asm/vdso/compat_gettimeofday.h b/arch/arm64/include/asm/vdso/compat_gettimeofday.h > > index c50ee1b7d5cd..fe7afe0f1a3d 100644 > > --- a/arch/arm64/include/asm/vdso/compat_gettimeofday.h > > +++ b/arch/arm64/include/asm/vdso/compat_gettimeofday.h > > @@ -17,6 +17,7 @@ > > #define VDSO_HAS_CLOCK_GETRES 1 > > > > #define VDSO_HAS_32BIT_FALLBACK 1 > > +#define BUILD_VDSO32 1 > > > > static __always_inline > > int gettimeofday_fallback(struct __kernel_old_timeval *_tv, > > > > This patch is independent from the rest and touches only arch code. Can it go in > via the arm64 tree? Why not take it via -tip along with patch 6? Otherwise we'll get a silly conflict. I'd assumed this series was going in as one thing. Will