Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2103428ybe; Tue, 3 Sep 2019 08:03:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqz9EdvfmslKmxiB9vLF5OuTz/7qSFU1XvFWpaRXxw/6LtzusbFWctxLFGOaS8Nzykvuw7zB X-Received: by 2002:a17:902:bc47:: with SMTP id t7mr35331789plz.329.1567523007745; Tue, 03 Sep 2019 08:03:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567523007; cv=none; d=google.com; s=arc-20160816; b=eXRPAGfASlaBHPvjEmVGZlZkUI38Jw1W9DujVg2mq1uR9OZm0Nkp1qOgd7mwaMMTJP Jnl65SWjOvKMZhArJmYN7N9WraRN2ZP5xZh5xZqrGuUvQB3CwOdnmmc1On4W6ZII1YS+ 4VJsLUrsLTXsYJol4ZQUykkrwPc85tNKSrbwhGs5QwCGGi26QKwUsvbV1takD0s/vgPN psUPWDcBGDrX5/H75fZBAtKMPTumFcX/lSWo49XsdhbC8YvIW4aqFMYZMbKfBEqm6qLb vZpvJNcbsVMFOJkt801Ih0wTiYVGIWWWAAzHuJOsxd7KaqGFgxzHubpsUOYkz9yuiGsZ Bs7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=OPXfuz6hZTmeN92lthXJwSEGks6dVJYEddMSbODEvhU=; b=PXxZZ2mInqgnZzz+Fe1ybvIXmc9GEDPpwiaykxkESFL+GVuC2buV0YGsITvDyvWyr7 BzDD3ZSvENbDZ7x+HoZHv6BO+ifIIMfY34LO+ccPMgNIkCKRouOToEuIqu0Tt0zOOkH4 P208bKSn2iZBLSZ/nsg+zg/chQ3czmymKuMwnLcZAOJFkXLw5m7ZM4Tv8+UxCtZNJMFY 1Sx4ZL0GOe64h5LCJ9Ui03ksadsVmgDaC58YDmlaF6B99LFsrHcO2vOgGuy87S+i4Usb GZpseXSvUBugTn7EgNVfCuowDNpXvIm5xtR0hOHZpAOa7QGI3jejlDeBYuL1kwcBGoUu iHZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=fenYEanL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q23si14878605pjp.76.2019.09.03.08.02.56; Tue, 03 Sep 2019 08:03:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=fenYEanL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729763AbfICPA6 (ORCPT + 99 others); Tue, 3 Sep 2019 11:00:58 -0400 Received: from mout.web.de ([212.227.17.12]:37845 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729734AbfICPA4 (ORCPT ); Tue, 3 Sep 2019 11:00:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1567522847; bh=OPXfuz6hZTmeN92lthXJwSEGks6dVJYEddMSbODEvhU=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=fenYEanL7PhoyyfbqRR6NNIRRhBOvFTDfVDw5sCh7MPIOgZ1k5Q3Lf3nCgZxi8nkr /JPN3lmPRdOgepYvuiPeXjdt7/imOEjmn4vDj4LTkjRboA7zaMrIRXrXiWeVKEURKx pHS4zvkwX287adttGsf1gsO+6SBnZVNeIjpDrebo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.133.133.43]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MCZlG-1hvquL07X8-009Rj7; Tue, 03 Sep 2019 17:00:47 +0200 Subject: Re: gfs2: Delete an unnecessary check before brelse() To: =?UTF-8?Q?Andreas_Gr=c3=bcnbacher?= , cluster-devel Cc: Andreas Gruenbacher , Bob Peterson , LKML , kernel-janitors@vger.kernel.org References: <9250af4a-993c-e86e-678c-acbd59b0861a@web.de> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <5e7b4313-c3e9-c3c8-8823-7c7a62a13fff@web.de> Date: Tue, 3 Sep 2019 17:00:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:qV6f4zP12+vEo6H/OZQRq4hKVxbP3qWg4Gs4xLjmOAC5vUWL9qy BTDxxyg634lf6loPjkd0pau6rA7JshC0QjBOSFTnuTYOYliyV8qoIbHeO0STsYGAalalv1G P1aImUszc8sTKDjfP1k81VhKOfkWVx1dkb082qxj0SdAckBc0TTguW+u8cPfs1jjySuxrlx RVSydqkkAhKnPxqvVvUcw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0Kt3zNk5ano=:J3pocg5T/OBQAkkdT5pBfd NsnO4wsTxG9L1MM1yIWMcbt2y6IfhKpJNodzV6lQB3D5cv2OUQFK2g5Prw9hyElVnrF/R1QM1 3aB66r7h4hI9Xl6tpkUGvSocbOiAFI7rLCYO9KjO2QU6rUI694p1ewb7z756Kyv7L4ouzmbPu cfR3flCFVw2VJsil7m64MD42omSzVJ9bIMBpMGIDgaTjKvNDcYECCXDPaS1+IlW+1hzEgutqr T6yJfinbW5j8HZvNBI8Wf6HDPHe1eHp8XPB8jI+xGvcdjjBl6hrAtIBfc+OyDXHmcZ4k7t003 84c4p3X7ldnMLSPOD/lYhG5aijE4kWJ7M+JCVCVj2osTJuZtg+A9GfRz7cPzW6MiWNtMCzx4i TgSCkpDvZQ+ok6IBj8tNgK5t062z4U2+kTAPZEV1fv64RZi5ooaReopKt1eGI1nlAM9FOy0Pf 3hlDPvHPhytn26beDYE7+crT6+mv6dJV32QMAsEpGq0UsB8tXS575d7G15kfDhytPZME5vWsZ 4BhpczNVst7iV4YS7QTKM6G5/lx1nXGtykUy5+qdQ5kaey8VYNHe+UR3FEsMnVlRGG4rm2EzG vr5jqjtL3otAxonJz4tEISsgkgwX98Dge9tPXkgEKfI5yELQ7/Eg1iMNNJRJo27tjoCsKvNH0 VInJIVKIY09/ff9pot+jsvPuZlX9nau1wRMT2bXQYjkw+ZZXV8Oo1tLJB5UVW9TegzpuvYfCV cTGRze0n/tTyBfRQGUoHs7CGLM7RONmLinTe39hR3ynG50RKvn+4GYVtB+aAH35hSusW5Lf1f YnPC4ddTc1SYbuOw+W2yvirBWaxSJ65TegBW6ws1bvukrOJq41xO9YJoWN8tZ2Sth4FXsJ8Yr PAdtc3/KcN8Xk2B7q8Hvt54+59CY9sLVvFvGeqvN32CALQvb8eug0JaHg/19d8i60Goc2e9aT IhKOI1Bqlspr5dE4u3KdH5tEQxIvjyE3aYN3OYNJQxuA01FaIQ+1oSF2K1XULaRHOOrjBlKgz H9lwagSb0qV/GAzshAm6SN5vpOfd89QAgzWfrFAzhU58kQ8ElDrQpbayGTPs6v6QfMsMjuWaR DgiJMAHZqujPUbDl5imLa8dmyE2FsXmWUhGx4NVP2l7FM9MUfqNMxoFLZaPKDNcLhzwddinB8 5htz3cQ7CA6kadlvO5JTFpyy4V8EXhPybiEjnVn02WbVyq0Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> The brelse() function tests whether its argument is NULL >> and then returns immediately. >> Thus the test around the call is not needed. >> >> This issue was detected by using the Coccinelle software. > > The same applies to brelse() in gfs2_dir_no_add > (which Coccinelle apparently missed), Would you like to achieve that such source code analysis will be extended to corresponding header files? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/f= s/gfs2/dir.h?id=3D7dc4585e03786f84d6e9dc16caa3ba5b8b44d986#n33 > so let me fix that as well. Thanks for your positive feedback. Regards, Markus