Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2154036ybe; Tue, 3 Sep 2019 08:43:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqwPsCOsDumS1272nBs6ifjsepekzWBnH2cyRjV4yPZ8vkL22fqdHfd59W932usfrf5WTzEx X-Received: by 2002:aa7:9f0e:: with SMTP id g14mr12787958pfr.100.1567525383030; Tue, 03 Sep 2019 08:43:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567525383; cv=none; d=google.com; s=arc-20160816; b=BFuZ89ypBiRLXplYiAczDw0UycnVQMY57zE23Z7WyqIFvpL2G4dcB1Df9dSdF8uDIs aWa+7Vr47e74tesEFJyOXNyMxHHIgzh8mF9A1JLCl48b3wrnoV5RUzTxNndqRzxux/BP UVIv/uSIwIxoymTqOZXlsunLzvzIw40ibKtg9Rmzb9mf8cN3jGNv5kbLOQc1BmTSZAnj +Sxy/NkOkB0s2g0JvxVmp+3bM1/fq7IJlBfPa2Fp7GX7AG0Lv04CrBYNaPaHBbMyaOTv 7I389YA6FUA06UiIsfabB1zNi/3HErHFbAjJry7wNbd8s1C68iT6spij6+ETEd4nJiP2 SUIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=HUfTn5r930K7rUr64CbqUuNN8Z5fUb8a0WbyTk8qcSE=; b=zZWMN6sV9w4yXYpNa9SQms3aGpveO7iAOgwUJWEkvFakbYsUUjUhKKiqZfEeCRPhup YyRW8eDCLTNnp2p8bcfl7EKADc75G51A3QkmqDhAH27X1l1G9x5aQqyrpfCWZpvsmwNx EdPcHyLSDHMmkCG6W5fcdLWc/+vgjBCvDCVa8tJ82LbEXeDGk6c2T0WvtmjKLn++WF7M xfjT7V3mwSM3T8gdIvPNjyI3hwgDmaZMBxv4rtgZuI0xZ3UF/QwRJM3D2/s9NlS21mOH kTrBfhpy2KxvqoNukXAP/04SvVSzhe96bevXgclclZfFqUqcOm/pHR/E7o3CJRo+rNEN eIcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17si7732264pls.383.2019.09.03.08.42.47; Tue, 03 Sep 2019 08:43:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729747AbfICPlz (ORCPT + 99 others); Tue, 3 Sep 2019 11:41:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35500 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727107AbfICPlz (ORCPT ); Tue, 3 Sep 2019 11:41:55 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8E59A155E0; Tue, 3 Sep 2019 15:41:54 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA15B5D6B2; Tue, 3 Sep 2019 15:41:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <156717343223.2204.15875738850129174524.stgit@warthog.procyon.org.uk> <156717352917.2204.17206219813087348132.stgit@warthog.procyon.org.uk> To: Casey Schaufler Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, Stephen Smalley , Greg Kroah-Hartman , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] smack: Implement the watch_key and post_notification hooks [untested] [ver #7] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4909.1567525310.1@warthog.procyon.org.uk> Date: Tue, 03 Sep 2019 16:41:50 +0100 Message-ID: <4910.1567525310@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 03 Sep 2019 15:41:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Casey Schaufler wrote: > I tried running your key tests and they fail in "keyctl/move/valid", > with 11 FAILED messages, finally hanging after "UNLINK KEY FROM SESSION". > It's possible that my Fedora26 system is somehow incompatible with the > tests. I don't see anything in your code that would cause this, as the > Smack policy on the system shouldn't restrict any access. Can you go into keyutils/tests/keyctl/move/valid/ and grab the test.out file? I presume you're running with an upstream-ish kernel and a cutting edge keyutils installed? David