Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2216023ybe; Tue, 3 Sep 2019 09:31:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqxxleO93sjIEqit83ujZmUO3vTwT769L/c8VEg4LTkuf4Wzmp2glDAS7ab1a3+X8ew6+HPU X-Received: by 2002:a17:902:5a06:: with SMTP id q6mr4394976pli.268.1567528267629; Tue, 03 Sep 2019 09:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567528267; cv=none; d=google.com; s=arc-20160816; b=I11i+Z3eybnBppr3lVCZNqyAEwqBktjVojvo76to21lxdCi2LFvVGTUcVP7ujbKSHx VIbm7sFieKtbQheb1nEMv1RgLJYb4MV1DoKzhdHToOLLHp6SUu5TLqzhHiyXLQUrK8jn XShzyhnvoNqYn8G9W0oOa1uJHv4gDZw6wPatQ9rCG907kOVkwoHcbobGRUtFyh+Zoztd 2Yztz+hps6CjH+179EOnJrq4UOXhiL7qeD6vxKVOFezd0UJRvoWShWAW5ie8bE7VagN2 gL6zfEqQxTvRBvByOfWdYPFh6OV9WpVlvTJDov806SReIA6p4TkRI9QfWW+0JgPo/0+C HR/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=xTsUxUgJ17vHPz6XZ5ZyHkBvqQFmSRaapICucPKyidE=; b=nIOKDCAAW4CCjrciEsk2S7MboJsCqu/T0Gr9n3XuD1olH54P7RqTogWj8MYvhAz8ZU lmiloOwdusxoJe7xkaUprWehHrFPAUotkeqxuvanBJb5vvDb/OUdjScHU/lElxMo+0/M Uuoi041fnuaDpXXUD3lMB95k7xgDj5NUb5bD+FD4TEsqUR8Bx6Xc7U8okNUffiWxxNOI XQTnTDiCb1SpeuQs1PAM67ITGw0eIfJvXmz+moVtAUFT5bmMhYFN58mhiRYWV2H4IkHC X2OoJoEa4jW9GIEoZpwhAmEPUXWxdlZM9sOSP3fN9FW4YO3A6mJH2FnnyrokE/RQ63HQ HRwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 184si14976897pga.23.2019.09.03.09.30.51; Tue, 03 Sep 2019 09:31:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730457AbfICQ31 (ORCPT + 99 others); Tue, 3 Sep 2019 12:29:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34172 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730333AbfICQ30 (ORCPT ); Tue, 3 Sep 2019 12:29:26 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 563E187521B; Tue, 3 Sep 2019 16:29:25 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57C0A19C78; Tue, 3 Sep 2019 16:29:22 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190903161202.GB22754@roeck-us.net> References: <20190903161202.GB22754@roeck-us.net> <20190903125129.GA18838@roeck-us.net> <156717343223.2204.15875738850129174524.stgit@warthog.procyon.org.uk> <156717350329.2204.7056537095039252263.stgit@warthog.procyon.org.uk> <7481.1567526867@warthog.procyon.org.uk> To: Guenter Roeck Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, Casey Schaufler , Stephen Smalley , Greg Kroah-Hartman , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/11] usb: Add USB subsystem notifications [ver #7] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29418.1567528161.1@warthog.procyon.org.uk> Date: Tue, 03 Sep 2019 17:29:21 +0100 Message-ID: <29419.1567528161@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Tue, 03 Sep 2019 16:29:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck wrote: > > > This added call to usbdev_remove() results in a crash when running > > > the qemu "tosa" emulation. Removing the call fixes the problem. > > > > Yeah - I'm going to drop the bus notification messages for now. > > > It is not the bus notification itself causing problems. It is the > call to usbdev_remove(). Unfortunately, I don't know how to fix it and don't have much time to investigate it right now - and it's something that can be added back later. David