Date: Wed, 21 Dec 2005 19:51:07 -0800 (PST)
Message-Id: <20051221.195107.113618698.davem@davemloft.net>
To: shemminger@osdl.org
Cc: mikukkon@iki.fi, bridge@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] BRIDGE: Fix faulty check in
 br_stp_recalculate_bridge_id()
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <20051221132527.1ef12bcf@dxpl.pdx.osdl.net>
References: <20051221195527.GA24213@localhost.localdomain>
	<20051221132527.1ef12bcf@dxpl.pdx.osdl.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1388
Lines: 38

From: Stephen Hemminger <shemminger@osdl.org>
Date: Wed, 21 Dec 2005 13:25:27 -0800

> On Wed, 21 Dec 2005 21:55:27 +0200
> mikukkon@iki.fi wrote:
> 
> > I did a compile with extra gcc warnings, and found a bug in
> > net/bridge/br_stp_if.c function br_stp_recalculate_bridge_id():
> > compare_ether_addr() returns 0 if match, positive if not, so
> > checking it for negative is wrong. 
> > 
> > Signed-of-by: Mika Kukkonen <mikukkon@iki.fi>
 ...
> > diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
> > index ac09b6a..08c52c2 100644
> > --- a/net/bridge/br_stp_if.c
> > +++ b/net/bridge/br_stp_if.c
> > @@ -158,7 +158,7 @@ void br_stp_recalculate_bridge_id(struct
> >  
> >  	list_for_each_entry(p, &br->port_list, list) {
> >  		if (addr == br_mac_zero ||
> > -		    compare_ether_addr(p->dev->dev_addr, addr) < 0)
> > +		    compare_ether_addr(p->dev->dev_addr, addr))
> >  			addr = p->dev->dev_addr;
> >  
> >  	}
> 
> Actually that compare_ether_addr needs to be replaced by memcmp again.
> Because for bridge id calc it wants the min() of all the device addresses.

I'll hold on this patch until that is worked out.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/