Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190903144632.26299-1-benjamin.tissoires@redhat.com>
In-Reply-To: <20190903144632.26299-1-benjamin.tissoires@redhat.com>
From:   =?UTF-8?B?Sm/Do28gTW9yZW5v?= <mail@joaomoreno.com>
Date:   Tue, 3 Sep 2019 20:33:34 +0200
Message-ID: <CAHxFc3SXM6hkbpTGZCsWOk70tByHE8af59ftOBwahY4fL0Sz=g@mail.gmail.com>
Subject: Re: [PATCH v2] HID: apple: Fix stuck function keys when using FN
To:     Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     Jiri Kosina <jikos@kernel.org>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Benjamin,

On Tue, 3 Sep 2019 at 16:46, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
>
> From: Joao Moreno <mail@joaomoreno.com>
>
> This fixes an issue in which key down events for function keys would be
> repeatedly emitted even after the user has raised the physical key. For
> example, the driver fails to emit the F5 key up event when going through
> the following steps:
> - fnmode=3D1: hold FN, hold F5, release FN, release F5
> - fnmode=3D2: hold F5, hold FN, release F5, release FN
>
> The repeated F5 key down events can be easily verified using xev.
>
> Signed-off-by: Joao Moreno <mail@joaomoreno.com>
> Co-developed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>
> Hi Joao,
>
> last chance to pull back :)
>
> If you are still happy, I'll push this version
>
> Cheers,
> Benjamin
>

Looks great. Thanks a bunch for your help!

Cheers,
Jo=C3=A3o

>  drivers/hid/hid-apple.c | 49 +++++++++++++++++++++++------------------
>  1 file changed, 28 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index 81df62f48c4c..6ac8becc2372 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -54,7 +54,6 @@ MODULE_PARM_DESC(swap_opt_cmd, "Swap the Option (\"Alt\=
") and Command (\"Flag\")
>  struct apple_sc {
>         unsigned long quirks;
>         unsigned int fn_on;
> -       DECLARE_BITMAP(pressed_fn, KEY_CNT);
>         DECLARE_BITMAP(pressed_numlock, KEY_CNT);
>  };
>
> @@ -181,6 +180,8 @@ static int hidinput_apple_event(struct hid_device *hi=
d, struct input_dev *input,
>  {
>         struct apple_sc *asc =3D hid_get_drvdata(hid);
>         const struct apple_key_translation *trans, *table;
> +       bool do_translate;
> +       u16 code =3D 0;
>
>         if (usage->code =3D=3D KEY_FN) {
>                 asc->fn_on =3D !!value;
> @@ -189,8 +190,6 @@ static int hidinput_apple_event(struct hid_device *hi=
d, struct input_dev *input,
>         }
>
>         if (fnmode) {
> -               int do_translate;
> -
>                 if (hid->product >=3D USB_DEVICE_ID_APPLE_WELLSPRING4_ANS=
I &&
>                                 hid->product <=3D USB_DEVICE_ID_APPLE_WEL=
LSPRING4A_JIS)
>                         table =3D macbookair_fn_keys;
> @@ -202,25 +201,33 @@ static int hidinput_apple_event(struct hid_device *=
hid, struct input_dev *input,
>                 trans =3D apple_find_translation (table, usage->code);
>
>                 if (trans) {
> -                       if (test_bit(usage->code, asc->pressed_fn))
> -                               do_translate =3D 1;
> -                       else if (trans->flags & APPLE_FLAG_FKEY)
> -                               do_translate =3D (fnmode =3D=3D 2 && asc-=
>fn_on) ||
> -                                       (fnmode =3D=3D 1 && !asc->fn_on);
> -                       else
> -                               do_translate =3D asc->fn_on;
> -
> -                       if (do_translate) {
> -                               if (value)
> -                                       set_bit(usage->code, asc->pressed=
_fn);
> -                               else
> -                                       clear_bit(usage->code, asc->press=
ed_fn);
> -
> -                               input_event(input, usage->type, trans->to=
,
> -                                               value);
> -
> -                               return 1;
> +                       if (test_bit(trans->from, input->key))
> +                               code =3D trans->from;
> +                       else if (test_bit(trans->to, input->key))
> +                               code =3D trans->to;
> +
> +                       if (!code) {
> +                               if (trans->flags & APPLE_FLAG_FKEY) {
> +                                       switch (fnmode) {
> +                                       case 1:
> +                                               do_translate =3D !asc->fn=
_on;
> +                                               break;
> +                                       case 2:
> +                                               do_translate =3D asc->fn_=
on;
> +                                               break;
> +                                       default:
> +                                               /* should never happen */
> +                                               do_translate =3D false;
> +                                       }
> +                               } else {
> +                                       do_translate =3D asc->fn_on;
> +                               }
> +
> +                               code =3D do_translate ? trans->to : trans=
->from;
>                         }
> +
> +                       input_event(input, usage->type, code, value);
> +                       return 1;
>                 }
>
>                 if (asc->quirks & APPLE_NUMLOCK_EMULATION &&
> --
> 2.19.2
>