Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2439857ybe; Tue, 3 Sep 2019 12:54:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1exRdrF3OH0v/QEGqK8yygfHwVPPEFOExhMrG73ZZKIv5K60AVQTCZfbq2XCzIf4XlJ/8 X-Received: by 2002:a17:90a:bf0e:: with SMTP id c14mr1026906pjs.140.1567540471757; Tue, 03 Sep 2019 12:54:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567540471; cv=none; d=google.com; s=arc-20160816; b=HxPYdEO2w4E/hwJv7ilHGG8R8ItSx3X6qXwMf9KBzQz22WqmlsdpPXwn30YOf5vXOX HAGj8dR8sm7wHMvolzOGTYimylYkXODtZKGQkI9Df/sE5Bf4bXwiH/AP4ECbxMKBUHOy TwQpFCxuXLzy60TrwIR8dHh/wwhDBYmuQC1AjfXij1CuUwHpg1nX0P1EEKk2V5/VA3ck Fsg6xUECyS03vXvs1ra6vd38rCiMZ31PX6RjU6z4vj+6sLX1IJCsdDE79aHMAK694efS VBwkWb/YEsytCjrIAeGo4ZR4ZzTPE89A2h2BRvK+CUGuCLzZ25+t38nE8TRvxt+D5eH2 a35A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:organization :subject:cc:to:from; bh=jyWJwzw0//kpOrBoa3gP9RpejpLfbTvqanxCWsgfeOw=; b=HKbjabqbSzwo+jUoE1zG1oPHDvvuQTKAfz6jDcRhsp3EA8N7UCU7Y//Ey+Ie+y4Fey vjiPVclbn3/Xwc69MPiLUOPcec+jqMY5sxfov+jI+ujE6ADbgqwfbRTNt4dCKTMfAghL 9oJGKmJHmz2TyzeR5df73aO3zeH3MpPWBGFav8tNpMt6nWBoljmEk+955jj0y8kj67F2 q2PxYLbABjflKCGQ5X1JbOEmi3QhxGd9hcbjpSzcms+LLBZfdrA1kZyzuh15VQOH4BDV cnro0RcCY7VRKFHiKsq5J5sRJQJv3PZcQHCRuyiLexay1YNtuqMV2QneagG1Xam9a6bY 4P9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w188si18511859pfb.175.2019.09.03.12.54.15; Tue, 03 Sep 2019 12:54:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726567AbfICTwH convert rfc822-to-8bit (ORCPT + 99 others); Tue, 3 Sep 2019 15:52:07 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:38940 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725953AbfICTwH (ORCPT ); Tue, 3 Sep 2019 15:52:07 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 6D44028B13F From: Gabriel Krisman Bertazi To: Krzysztof Wilczynski Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] unicode: Move static keyword to the front of declarations Organization: Collabora References: <20190830131349.14074-1-kw@linux.com> Date: Tue, 03 Sep 2019 15:52:01 -0400 In-Reply-To: <20190830131349.14074-1-kw@linux.com> (Krzysztof Wilczynski's message of "Fri, 30 Aug 2019 15:13:49 +0200") Message-ID: <85blw1gntq.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Krzysztof Wilczynski writes: > Move the static keyword to the front of declarations of nfdi_test_data > and nfdicf_test_data, and resolve the following compiler warnings that > can be seen when building with warnings enabled (W=1): > > fs/unicode/utf8-selftest.c:38:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > fs/unicode/utf8-selftest.c:92:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > Applied. Thanks, -- Gabriel Krisman Bertazi