Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2450531ybe; Tue, 3 Sep 2019 13:04:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLJur5qoIQ9wZjKff5zL/7YBWekJmv/aTxwdAlwNJ2E8jhEBDZP4VsxGQT6Bf2wQhRJlm4 X-Received: by 2002:aa7:9112:: with SMTP id 18mr5312501pfh.127.1567541073889; Tue, 03 Sep 2019 13:04:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567541073; cv=none; d=google.com; s=arc-20160816; b=NY/YAF1t0UJFO6jzvI3xEUjd73TTP9PMhT0aQrWHDMgTA4lMROrPAbtYnLtRfVdSdY XaII2cBj1puSF1uwqUnLv6N1RXNWZvWs6f0zbVAfqesQHFAEvpKhq3s8b6pTd+1dGWZD pW0sYWNlWP264aZIlNO4DiI7lH9WcQSQgnnLHM6NkVOs/yH7Jl4dGuOn9ZI150nK0vSI zvrAWvwi9KkPMao07ChFa/ZB6bxOXWdUEyLEYkQ6pvUyc+buau9W/47dK+2/3ThU/fYD QYWXFOHqf1qIjh6+F/ZJKNWxHU/JyBfPww9aL9pJ+FHA1cHocyeZeqhEuypxKUlp+lPj guWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Xtu5kCfKIPXCIcohKh9ObaTr4LwhKRJeIYCPiDumG4E=; b=d/G1XUmLp/N21u5lSIk3bWlqg3SzLw1hkw/nnwMbPinZ03ENXT9KM7+72HCkV1JCWV 1/Dbge2Lv9KYl9XdToKituhZnZKN2uSDCer/eZcqySbGusUVsZ8cjLWYd8NP0f1fTaTz MryMslEyl+k/zeXM8mmXi72CJILOgSN5d+1FzW7PsSKH+2m+ws5tF5NJVaUVVrwBOAT6 QdumKAD3xwXvqNen6x2B3gr1fq+duBhc+HdUF5fe1083uz3yZSdhvyv2xIT34+vHjaR5 7kKYWZ+WZzag0ZXXvIoaLSmJB5zUUrqbpgWZ4/1s3tiEfAMONufYtibnZ3BwdDSM6q6T EWew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l5SKO1WB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l70si15176337pgd.363.2019.09.03.13.04.17; Tue, 03 Sep 2019 13:04:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l5SKO1WB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726508AbfICUBm (ORCPT + 99 others); Tue, 3 Sep 2019 16:01:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:47600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfICUBl (ORCPT ); Tue, 3 Sep 2019 16:01:41 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A84821881; Tue, 3 Sep 2019 20:01:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567540900; bh=8IoII2n9C/TCOkc678nbcBwVHhhtTdLM2AVpeiA6uaI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l5SKO1WB6Tt9zijJa1tqc7RReLLGhR8WvGG0eq5XOUZ52tbbmNzgLVyNe5svU9CQd 091vLYWKFeESf2N+GDEXSWANWJJBTfatlbv+/8w7AV+JOMZnTdCw3hSGWfQijUBY4y E30ECyBZYkC6HiikEzSXx34mtJs05AUj05QyNFmk= Date: Tue, 3 Sep 2019 16:01:39 -0400 From: Sasha Levin To: Greg KH Cc: Michel =?iso-8859-1?Q?D=E4nzer?= , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yu Zhao , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Deucher Subject: Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment Message-ID: <20190903200139.GJ5281@sasha-vm> References: <20190903162519.7136-1-sashal@kernel.org> <20190903162519.7136-44-sashal@kernel.org> <7957107d-634f-4771-327e-99fdd5e6474e@daenzer.net> <20190903170347.GA24357@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190903170347.GA24357@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote: >On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel D?nzer wrote: >> On 2019-09-03 6:23 p.m., Sasha Levin wrote: >> > From: Yu Zhao >> > >> > [ Upstream commit 89f23b6efef554766177bf51aa754bce14c3e7da ] >> >> Hold your horses! >> >> This commit and c4a32b266da7bb702e60381ca0c35eaddbc89a6c had to be >> reverted, as they caused regressions. See commits >> 25ec429e86bb790e40387a550f0501d0ac55a47c & >> 92b0730eaf2d549fdfb10ecc8b71f34b9f472c12 . >> >> >> This isn't bolstering confidence in how these patches are selected... > >The patch _itself_ said to be backported to the stable trees from 4.2 >and newer. Why wouldn't we be confident in doing this? > >If the patch doesn't want to be backported, then do not add the cc: >stable line to it... This patch was picked because it has a stable tag, which you presumably saw as your Reviewed-by tag is in the patch. This is why it was backported; it doesn't take AI to backport patches tagged for stable... The revert of this patch, however: 1. Didn't have a stable tag. 2. Didn't have a "Fixes:" tag. 3. Didn't have the usual "the reverts commit ..." string added by git when one does a revert. Which is why we still kick patches for review, even though they had a stable tag, just so people could take a look and confirm we're not missing anything - like we did here. I'm not sure what you expected me to do differently here. -- Thanks, Sasha