Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2478099ybe;
        Tue, 3 Sep 2019 13:33:16 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwg1p5oz/m0OaNzdaetYOOfmICQTI/PCN0mJvYVl0XTi/+XZsyX0dSrDPeP49FH+OEcQt/5
X-Received: by 2002:a62:5ac1:: with SMTP id o184mr179443pfb.67.1567542796517;
        Tue, 03 Sep 2019 13:33:16 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1567542796; cv=none;
        d=google.com; s=arc-20160816;
        b=c+8BEwYBGCzOMDmSCBOMdCCFeGB3jhoXg+XmOvwurwcH/LM83bBB1lX2f39PGI10w6
         yg2wVakMeuryEC8gosMws/33wccuH3piyJuEENRHel9tMQZq8s6s3QJJPza6TiHSB8LV
         WBehl4sYWMpHdrccrZyZ1C0zdwAF2K2Dphj8MZJTIUhlogVNAx2kIGj7xGq7j5xu5FDb
         7dsTN90sivgcI21OlcyAKVKbzm4Bc8tiEu20T7mJK72yFQspYULRbEKTjpownl6nrglT
         Gx53BGrc5E9h/I6I7F7fu0x4aJ6txIR/15Zn4vhg0iMqOWfJZA8Kuzlw4iIkTh9tvYI0
         nJCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=rkAXxUbkzoKNx1xrG9Gx5bwiXnyk9OERTgT/X+lUJ9A=;
        b=AduKLAbMqyrvWVvCVrQBov/OGvCqWX6TSX8adgSRKawT7l7UxgEvnZCKoLvyxdCUX7
         egJVqC+pUo/SgmbhVTWP3HOktCXcJO2FpDRf5+xM35Q3sNFlBVvbgUqFKiC4lkmWmlfi
         UzXWjzTU8B+hlr+AHn/0Nkpw6KXf4ZXBe1JNTdpy9o62TnCVWA3fyk+kIvbqn3zfTAfx
         6zB+cCyOvQid5YDlUshuGae6m3hcX2rm4IvyZ2Nn3BqtWMdbCnqDLXsdEWsD1yToe5ML
         cNBO7nFPvitGzruBJsFdUi7roJfZABjHupzC1u2CUyzq2WgPWLAJmb9gUQ3VBnTCX8ax
         9eTA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id x18si7723375pfm.213.2019.09.03.13.33.00;
        Tue, 03 Sep 2019 13:33:16 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726589AbfICUak (ORCPT <rfc822;wxiaokuan@gmail.com> + 99 others);
        Tue, 3 Sep 2019 16:30:40 -0400
Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:38248 "EHLO
        atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725962AbfICUak (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 3 Sep 2019 16:30:40 -0400
Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)
        id E3DD480F8A; Tue,  3 Sep 2019 22:30:23 +0200 (CEST)
Date:   Tue, 3 Sep 2019 22:30:36 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Akinobu Mita <akinobu.mita@gmail.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        linux-leds@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH] leds: remove PAGE_SIZE limit of
 /sys/class/leds/<led>/trigger
Message-ID: <20190903203036.GA923@bug>
References: <1567090164-6819-1-git-send-email-akinobu.mita@gmail.com>
 <6ebeedab-4a7f-14ea-d62e-9184e911047f@gmail.com>
 <20190902181207.GA18577@kroah.com>
 <1cd468a3-b6e5-a93b-739a-f30288318356@gmail.com>
 <20190902190843.GB25019@kroah.com>
 <CAC5umyjTJSMdKMtZbF8Uxky6nOrAHesTHmZRV5VA1uPwX2rtxA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAC5umyjTJSMdKMtZbF8Uxky6nOrAHesTHmZRV5VA1uPwX2rtxA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

> > Also, you all didn't document the heck out of this.  So no, I really do
> > not want to see this patch accepted as-is.
> >
> > > Provided that will be fixed, can we count on your ack for the
> > > implementation of the solution you proposed? :-)
> >
> > Let's see the patch that actually implements what I suggested first :)
> 
> I'd propose introducing a new procfs file (/proc/led-triggers) and new
> /sys/class/leds/<led>/current-trigger api.

No.

Your patch is good, it just needs adding comment:
 /* It was stupid to create 10000 cpu triggers, but we are
stuck with it now. Don't make that mistake again. We work around it here by creating binary
attribute, which is not limited by length. This is _not_ good design, do not copy it. */

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html