Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2494827ybe; Tue, 3 Sep 2019 13:52:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxazrKkc+VZ+E9nx1uJc6OWUk71l1ZNjYfNZJ4mMlSgnoAuHRMqWRoADots43Htq3XTNHGF X-Received: by 2002:a17:90a:f011:: with SMTP id bt17mr1242912pjb.21.1567543939582; Tue, 03 Sep 2019 13:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567543939; cv=none; d=google.com; s=arc-20160816; b=Acp/vWrN5WvbOaIqpoKGXyMXHFfKh9D/KLB4HzwFwJA7yticvVAnZ3mdJpOWhozkUN bmHk95a4OQf5P/3SSRHddjkrbQ38jpDdFAkk8U3grte1KBK7ZRcB/DnDOUg67wezAous f6+Xt3ajayoc3HfYlYvLroMK/uH1Hbdvq4xq2g+1ExK7f1pkBRBWbNpVSXkqtkN+zxa+ gO06CLN/Dt4QYbQoRBzLFNQvHiCb612Rka74INFMHDBHoVDo2Xnu3l7Gj071FhaFuAlo sDVdxc4nzDVmuo4vuUcbtZGv9y0BSyaZJveWXZRir/HKDukKmZb2ixm1G9RgUIJwhIkd HBmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=lD1C8da/NYJMad1Ik6fox/MJMen3MFfo1sJEycwg2Dw=; b=Uf9X0uElJEFPweCWNgkqIBeZqWUL6CLKB9LZW/ePVghWHYxLYC3RLCVEdG7TWYcuBc 5xG4j/QzB27vRssktuyn3y46qFGU01Y6LyQd+Vh6b4AGggmYD1VpJbGoDpi6FzPgt++V pVRG+QuPNUFxSule/3/ZMYkxf2aeNMLoQq+EzGdfMRpORw4a+5BsOplZjumTkXyhapW/ IaO01dAKr9DIuj8Q4mlbZLzvbrHWffczPrHuZSgSC2mLImcKHllH9qpxNaXyAVWRffC1 6taV9wZhiM5oF8rv0R4nwqX5278Dlx4gQS4BPi7Hn+c76AtsmZUGta0ROEoPGjI7Wi+9 UEdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l20si11880561pgj.442.2019.09.03.13.52.01; Tue, 03 Sep 2019 13:52:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbfICUsc (ORCPT + 99 others); Tue, 3 Sep 2019 16:48:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39710 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727716AbfICUs3 (ORCPT ); Tue, 3 Sep 2019 16:48:29 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8459618C4269; Tue, 3 Sep 2019 20:48:29 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-34.bss.redhat.com [10.20.1.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36C601001B08; Tue, 3 Sep 2019 20:48:26 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Cc: Juston Li , Imre Deak , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Harry Wentland , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v2 14/27] drm/dp_mst: Destroy topology_mgr mutexes Date: Tue, 3 Sep 2019 16:45:52 -0400 Message-Id: <20190903204645.25487-15-lyude@redhat.com> In-Reply-To: <20190903204645.25487-1-lyude@redhat.com> References: <20190903204645.25487-1-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Tue, 03 Sep 2019 20:48:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Turns out we've been forgetting for a while now to actually destroy any of the mutexes that we create in drm_dp_mst_topology_mgr. So, let's do that. Cc: Juston Li Cc: Imre Deak Cc: Ville Syrjälä Cc: Harry Wentland Cc: Daniel Vetter Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 74161f442584..2f88cc173500 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -4339,6 +4339,11 @@ void drm_dp_mst_topology_mgr_destroy(struct drm_dp_mst_topology_mgr *mgr) mgr->aux = NULL; drm_atomic_private_obj_fini(&mgr->base); mgr->funcs = NULL; + + mutex_destroy(&mgr->delayed_destroy_lock); + mutex_destroy(&mgr->payload_lock); + mutex_destroy(&mgr->qlock); + mutex_destroy(&mgr->lock); } EXPORT_SYMBOL(drm_dp_mst_topology_mgr_destroy); -- 2.21.0