Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2499339ybe; Tue, 3 Sep 2019 13:57:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3NLwNdt5nGaSzsDOfnQ8P45m8Y7tDp0yhD0+ahHpxBDCFQv1//d5fUzUI24ir2XWNLRPq X-Received: by 2002:a17:902:9041:: with SMTP id w1mr37946490plz.83.1567544261931; Tue, 03 Sep 2019 13:57:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567544261; cv=none; d=google.com; s=arc-20160816; b=M8tDphJ3T1K5r2fvlr0Nt+PxKcbMcdEFu/cwtPNiuQMlFPPaUK5/Pvvwtjki7ArSWo QCrleawQ5Y0nyt43Pxom4am1c0z30NV/wy07amBnR8FoMDc/SYWuPh0rVyszXum+u8uf gCYIo8OFlUUpYtCUjn3B4GRPrx7Vkvdgyo2L+szSpzkCLJsHEm3UQiZZlb8306869GmJ VUfn+9a9ZgM0grTPHj8F06alyNIqmpYw8kcXk8oo+aYoQzlPnvN05bSG3uNzhjlPCHR9 u7paqIHksSHsi6iEvItMerfzH8+cLzI6pIVxSi1Zl78e9UTuY8XqjopkSZdTn9zMQlbZ iH3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=67o0yb/2dQr9dDwwfIN2yNbgtif2zveVf3XD61aSskY=; b=qX1j5CFvYbCTkULGRYvzbTCg/2va16MPKrZxDUvbBhRJ5HzBOIeyNok/uWfLo05G/V hthHFno5yMHe/Y1F03lz62P3tmtMd/qFtR32stslSj5lxNUDCjRRNwTsNEX0FbPO6vB8 qWiuLSJbxO5qp1QreLmW8rqEW/uDfJjZg3Vp8sflULTScRDNMV7rUhNSYK5VdH3fqhuJ Xj9YljocVppYcyjASyULfBMd83NlHE/nWHIK3Of/IPPu8tJHOWHSkBcWjWcsXJxmW3FB Dumq7RWVXw4ouuhPkKsQ4smNIZWTS2cnEh4bK6BXFmIovpFu3HiHG7u4aqo5oH4hWBT2 OWgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x184si18864771pfb.24.2019.09.03.13.57.26; Tue, 03 Sep 2019 13:57:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727018AbfICUzP (ORCPT + 99 others); Tue, 3 Sep 2019 16:55:15 -0400 Received: from correo.us.es ([193.147.175.20]:34096 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727043AbfICUzP (ORCPT ); Tue, 3 Sep 2019 16:55:15 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 05BD0B6C6F for ; Tue, 3 Sep 2019 22:55:11 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id EBB5CDA72F for ; Tue, 3 Sep 2019 22:55:10 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id D15B4B8005; Tue, 3 Sep 2019 22:55:10 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C6D4BD2B1F; Tue, 3 Sep 2019 22:55:08 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 03 Sep 2019 22:55:08 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 93DE84265A5A; Tue, 3 Sep 2019 22:55:08 +0200 (CEST) Date: Tue, 3 Sep 2019 22:55:09 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Florian Westphal Cc: Leonardo Bras , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jozsef Kadlecsik , Roopa Prabhu , Nikolay Aleksandrov , "David S. Miller" Subject: Re: [PATCH v4 1/2] netfilter: Terminate rule eval if protocol=IPv6 and ipv6 module is disabled Message-ID: <20190903205509.y6bus5gw4jdw5d7l@salvia> References: <20190830181354.26279-1-leonardo@linux.ibm.com> <20190830181354.26279-2-leonardo@linux.ibm.com> <20190830205802.GS20113@breakpoint.cc> <99e3ef9c5ead1c95df697d49ab9cc83a95b0ac7c.camel@linux.ibm.com> <20190903164948.kuvtpy7viqhcmp77@salvia> <20190903170550.GA13660@breakpoint.cc> <20190903193155.v74ws47zcn6zrwpr@salvia> <20190903194809.GD13660@breakpoint.cc> <20190903201904.npna6dt25ug5gwvd@salvia> <20190903203531.GF13660@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903203531.GF13660@breakpoint.cc> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 10:35:31PM +0200, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > On Tue, Sep 03, 2019 at 09:48:09PM +0200, Florian Westphal wrote: > > > We could do that from nft_do_chain_netdev(). > > > > Indeed, this is all about the netdev case. > > > > Probably add something similar to nf_ip6_route() to deal with > > ip6_route_lookup() case? This is the one trigering the problem, right? > > Yes, this particular problem is caused by ipv6 fib not being > initialized due to ipv6.disable=1. I don't know if there are cases > other than FIB. > > > BTW, how does nft_fib_ipv6 module kicks in if ipv6 module is not > > loaded? The symbol dependency would pull in the IPv6 module anyway. > > ipv6.disabled=1 does load the ipv6 module, but its non-functional. I see, thanks for explaining.