Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Kobayashi, Kento (Sony)" <Kento.A.Kobayashi@sony.com>
To:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Cao, Jacky" <Jacky.Cao@sony.com>
Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
Thread-Topic: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
Thread-Index: AdUr4fO63YeCnMxgQdWlMpYcyadcJAOxqk0ACg+lZqA=
Date:   Wed, 4 Sep 2019 06:12:11 +0000
Message-ID: <OSAPR01MB49300F8CA0956F031CA4B1ECC9B80@OSAPR01MB4930.jpnprd01.prod.outlook.com>
References: <16EA1F625E922C43B00B9D8225022050086ECF6A@APYOKXMS108.ap.sony.com>
 <16EA1F625E922C43B00B9D8225022050086F86B4@APYOKXMS108.ap.sony.com>
In-Reply-To: <16EA1F625E922C43B00B9D8225022050086F86B4@APYOKXMS108.ap.sony.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: sony.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 71793a6d-eea6-4e51-8b4f-08d730fed323
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2019 06:12:11.4165
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hxPP7z0UVohPAJJ+HJ4Aq0Jey+vZpxA+AGYdvX4iY0J3Gl+L4O3ENvOP4uXRvx4UWG/eW3UaimINcpbn3l105WrSb7Za1TfVWtoTo1NuibA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB4098
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

My company's member, Mr.Jacky, sent patch in June 26th.
But we didn't receive comment about our patch.
Could you confirm and tell us this patch is needed or not?

Regards,
Kento Kobayashi


From: Cao, Jacky <Jacky.Cao@sony.com>=20
Sent: Monday, July 15, 2019 10:05 AM
To: balbi@kernel.org; gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Kobayashi, Ken=
to (Sony) <Kento.A.Kobayashi@sony.com>; Cao, Jacky <Jacky.Cao@sony.com>
Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

Hi,=20

Since around half month past, let me confirm the status of this issue.
If any comment about the fix patch, would you kind to share with us?=20
Thank you.

Best Regards
Jacky

From: Cao, Jacky=20
Sent: Wednesday, June 26, 2019 1:48 PM
To: mailto:balbi@kernel.org; mailto:gregkh@linuxfoundation.org; mailto:linu=
x-usb@vger.kernel.org; mailto:linux-kernel@vger.kernel.org
Cc: Kobayashi, Kento (Sony) <mailto:Kento.A.Kobayashi@sony.com>; Cao, Jacky=
 <mailto:Jacky.Cao@sony.com>
Subject: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

The power budget for SuperSpeed mode should be 900 mA
according to USB3.0 specification, so set the power
budget to 900 mA for dummy_start_ss which is only used
for SuperSpeed mode.

If the max power consumption of SuperSpeed device is
larger than 500 mA, insufficient available bus power
error happens in usb_choose_configuration function
when the device connects to dummy hcd.

Signed-off-by: Jacky Cao <mailto:Jacky.Cao@sony.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du=
mmy_hcd.c
index 8414fac..52f2cf5 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -48,6 +48,7 @@
#define DRIVER_VERSION "02 May 2005"

=A0#define POWER_BUDGET=A0 500=A0 /* in mA; use 8 for low-power port testin=
g */
+#define POWER_BUDGET_3_0=A0 900=A0 /* in mA */

=A0static const char=A0 driver_name[] =3D "dummy_hcd";
static const char=A0 driver_desc[] =3D "USB Host+Gadget Emulator";
@@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
=A0=A0=A0=A0 dum_hcd->rh_state =3D DUMMY_RH_RUNNING;
=A0=A0=A0=A0 dum_hcd->stream_en_ep =3D 0;
=A0=A0=A0=A0 INIT_LIST_HEAD(&dum_hcd->urbp_list);
-=A0=A0=A0=A0 dummy_hcd_to_hcd(dum_hcd)->power_budget =3D POWER_BUDGET;
+=A0=A0=A0=A0 dummy_hcd_to_hcd(dum_hcd)->power_budget =3D POWER_BUDGET_3_0;
=A0=A0=A0=A0 dummy_hcd_to_hcd(dum_hcd)->state =3D HC_STATE_RUNNING;
=A0=A0=A0=A0 dummy_hcd_to_hcd(dum_hcd)->uses_new_polling =3D 1;
#ifdef CONFIG_USB_OTG
--=20
2.7.4