Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp403665ybe; Wed, 4 Sep 2019 01:21:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmjgXA+D2f8X6S+FWOhvDxSnTlYmcsiwnKSpX03AddqPPGRhq1uZb2dqC6hEEX2vgfd1zp X-Received: by 2002:a65:4189:: with SMTP id a9mr33101715pgq.399.1567585312652; Wed, 04 Sep 2019 01:21:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567585312; cv=none; d=google.com; s=arc-20160816; b=kq5K4OX5eiUk/SqwXs8zo7BKek6mvfVW+scwciOxTYB2rH1PakedkELG7LdpkNE7hB weNQG3fngG4huVOXuCogzZo5ek61Yr9GYm1BX3EAKqLfmR34wWE8oDW4R41Z1qfqCUIl lIafDiw18XIaWljnFSi6gjmTKk1SEJ5CfylVBPeK4AFwmME/4FkFUuvokQ6zbpltW4Yk Rzt9j1rlvdqgl2BZqtYwH7K3xsB52k9ONH2AdEJ3oD4thUqA/StmOtDhvYCdMCCc3c74 4TiC184iLfgkuY9RMVomrWycWEmx/tim0yivxSWbfSut748Jrln1LZ9TBXgbc+9D8sT6 XhJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CGQD9aajbZ43wWu0vn4K6MjrdAeqbwd4MhEaYZZjQSk=; b=YoDUrE9h3UVMsCecqBt0RtldMKIMhXW57sOLdetr3m9eO/R5SsukZaKeY4OaoxDyVd 64aiTN4vjjHlMlbXLZZNq4O3ychtuz1dSqT9bMhvn8fvITTOXnP0xnkew4y1Xpum6nrk jgQU+fOhkMNB2tLRQ/4S8l1gU6ithlwky9X6MRKsoc3X7ujAlu3xGRYWYsX6PTuGbimS PUfMtYZ78wJ8vtCpsdyHlMpS/yS7weowbRL/JfJ31FKTbwlntMUIX2/Hg494eLAbihcA sYbxswwBJSL0CV6kHFpopJA1CCDOp53uqz462fHfsfZONBf3Y+Jae7jRz7qcypwMOrNn PLFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=JGaSLy4W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v19si19740730pfm.56.2019.09.04.01.21.37; Wed, 04 Sep 2019 01:21:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=JGaSLy4W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbfIDIUv (ORCPT + 99 others); Wed, 4 Sep 2019 04:20:51 -0400 Received: from merlin.infradead.org ([205.233.59.134]:60260 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfIDIUv (ORCPT ); Wed, 4 Sep 2019 04:20:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CGQD9aajbZ43wWu0vn4K6MjrdAeqbwd4MhEaYZZjQSk=; b=JGaSLy4WvunqQWZaCJPgcF7RA fHOjCZpp5tBgxmE0BkCEYgAjVfmXkbPjqMH271bz04V3lClgnlMG03Jn7MSduvKtVcPXRDFES/GPg 76p3BD8bcZnXHQDqY3tvxMOVHk1vUzcvCeJkH9R3GNuSJyw11jjzRgccBr9WeQQnUlhVflP0s9xFE 5oqaA68cIc8YwyF2yzlCkA4Wxnizh+hmNYw5iHY6WoiKJpHYJMly5n3KzdqOmLKXSsO3T+qjXrYNt CohF74tq8QkLe8xlLwxDYEW4hwn8nHb+umVDv531FC2M6QonGNXs+Y9h5B6whSIqOafof4YLc9DXK IeLePlUIw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1i5QX1-0002Hz-LI; Wed, 04 Sep 2019 08:20:47 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E56BF3011DF; Wed, 4 Sep 2019 10:20:09 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 65EBA20977769; Wed, 4 Sep 2019 10:20:46 +0200 (CEST) Date: Wed, 4 Sep 2019 10:20:46 +0200 From: Peter Zijlstra To: Viktor Rosendahl Cc: Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, Joel Fernandes Subject: Re: [PATCH v5 1/4] ftrace: Implement fs notification for tracing_max_latency Message-ID: <20190904082046.GB2349@hirez.programming.kicks-ass.net> References: <20190903132602.3440-1-viktor.rosendahl@gmail.com> <20190903132602.3440-2-viktor.rosendahl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903132602.3440-2-viktor.rosendahl@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 03:25:59PM +0200, Viktor Rosendahl wrote: > It seems like it would be possible to simply replace the calls to > latency_fsnotify_enable/disable() with calls to > start/stop_critical_timings(). However, the main problem is that it > would not work for the wakup tracer. The wakeup tracer needs a > facility that postpones the notifications, not one that prevents the > measurements because all its measurements takes place in the middle > of __schedule(). On the other hand, in some places, like in idle and > the console we need start stop functions that prevents the > measurements from being make. Like Joel already mentioned; you can use irq_work here.