Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp462855ybe; Wed, 4 Sep 2019 02:33:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqyaLG4vc2SYO1rfFNzvmgTwN8A99o48vu3nHB/ZxpyUeq2ZCBqqjOR+BjJiO7npuLpClB48 X-Received: by 2002:a65:684a:: with SMTP id q10mr34636603pgt.417.1567589592599; Wed, 04 Sep 2019 02:33:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567589592; cv=none; d=google.com; s=arc-20160816; b=ED0eJ7oECW827+GNg8lHYKIUwMP84N0yJxtiXBVtV/vZY6+xhf6SR9RRL7STcZh2T+ bb9n6lHaFutRlTTZHHcth4OpTlGnA/wKRNVIhOXaoMgYeo5lrK2p7jX1J3YnlS37Tvla 1NifRJ6jFgFcqyroyuhd9kfL+uAKYOZrdb5olPSlD98emnqmpPibIcs/PhwiYtgOMHJz sFcVBcGlLXu4FTRZl+f7Jda2UnXQU61xCRwehnJQyqARcShmF/ENfxttAE35v9cSb4LX hHztisYEK1Wghay0uADk0sfueRrfnj4fthy6heM9Am5zwWr+Z61KTkNTKZRdSVubNJ7L bWuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qoKo7sJMjzzrj74O0TGKIRr9hicVuXBRQAq2VIQdMEE=; b=jbcYXWQGhF8Ljsvq8qLbBvb2tED1iZZ9u7UZCeZTShol5Q7sk6UrUMpWFn9HgEjk9W XUqg6xI34mhLZTe4bnFeEsTIQ7mY430eANWI1njST78i1J3yozxXIsvjFIi2mr9Nwc+U 8QQdkZrYhowHm/76DNRH1NewQEjtLEo6TCjUVXqSpDI4MGRN0e69DZIGgdqJrArzf7zm fT2y98VnV5B3jDVA2/Icq3xBLZDqm1DJT/ZxoQxxVFNgc2pvZOCu38OXf3slbQzIdWSI zoHofo7qHtKzoYaQg4DYsg6k6xrHRCm9+5YxwscaJblgffSmJgKYNL149NhKl1WYrq5I M5lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GtGomH9v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1si16951560pgd.263.2019.09.04.02.32.56; Wed, 04 Sep 2019 02:33:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GtGomH9v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729335AbfIDJcB (ORCPT + 99 others); Wed, 4 Sep 2019 05:32:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:52480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbfIDJcB (ORCPT ); Wed, 4 Sep 2019 05:32:01 -0400 Received: from localhost (unknown [122.182.201.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A6FA21670; Wed, 4 Sep 2019 09:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567589520; bh=WgIUy8LE9J87OsA/15aWqvYEgaNDugjXyzgcT2llIIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GtGomH9v7txv+9qLZ9tZuCxIymaWrnwtZSsPvbYLctwoeAEUuyslKGLcUZ/PKqz7q aOsrl7gZPrpoqor59+m+aIqPC1tIM4lZfBHb36sjPuufs3+zaeru6XFkFV+QiG5/ts f0KpSkqiYCQL0QnrTdu5DYpv7uaKvXHC1C7MCldM= Date: Wed, 4 Sep 2019 15:00:52 +0530 From: Vinod Koul To: Randy Dunlap Cc: Michal Suchanek , alsa-devel@alsa-project.org, Sanyog Kale , Pierre-Louis Bossart , linux-kernel@vger.kernel.org Subject: Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI Message-ID: <20190904093052.GQ2672@vkoul-mobl> References: <20190830185212.25144-1-msuchanek@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-08-19, 11:56, Randy Dunlap wrote: > On 8/30/19 11:52 AM, Michal Suchanek wrote: > > Fixes the following warning on !ACPI systems: > > > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but > > not used [-Wunused-function] > > static int sdw_slave_add(struct sdw_bus *bus, > > ^~~~~~~~~~~~~ > > > > Signed-off-by: Michal Suchanek > > Acked-by: Randy Dunlap > > I was about to send the same patch. So I have applied Srini's patches which add DT support and they use sdw_slave_add(). So next tomorrow should not see this error as it is now used by DT parts as well. So dropping this patch -- ~Vinod