Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     =?iso-8859-2?Q?=27Valentin_Vidi=E6=27?= 
        <vvidic@valentin-vidic.from.hr>, Al Viro <viro@zeniv.linux.org.uk>
CC:     Valdis Kletnieks <valdis.kletnieks@vt.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] staging: exfat: cleanup braces for if/else statements
Thread-Topic: [PATCH] staging: exfat: cleanup braces for if/else statements
Thread-Index: AQHVYoMgt2lCAY06IEWAL3uRVSEYfacbQ6fg
Date:   Wed, 4 Sep 2019 09:38:55 +0000
Message-ID: <d14cda319c584db9b8aa35b15b542f89@AcuMS.aculab.com>
References: <20190903164732.14194-1-vvidic@valentin-vidic.from.hr>
 <20190903173249.GL1131@ZenIV.linux.org.uk>
 <20190903181208.GA8469@valentin-vidic.from.hr>
In-Reply-To: <20190903181208.GA8469@valentin-vidic.from.hr>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Valentin Vidic
> Sent: 03 September 2019 19:12
> On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote:
> > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote:
> > > +			} else if (uni == 0xFFFF) {
> > >  				skip = TRUE;
> >
> > While we are at it, could you get rid of that 'TRUE' macro?
> 
> Sure, but maybe in a separate patch since TRUE/FALSE has more
> calls than just this.

I bet you can get rid of the 'skip' variable and simplify the code
by using continue/break/return (or maybe goto).

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)