Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Sep 2019 06:37:15 -0400
From:   "Michael S. Tsirkin" <mst@redhat.com>
To:     Nadav Amit <namit@vmware.com>
Cc:     Jason Wang <jasowang@redhat.com>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] mm/balloon_compaction: suppress allocation warnings
Message-ID: <20190904063703-mutt-send-email-mst@kernel.org>
References: <20190820091646.29642-1-namit@vmware.com>
 <ba01ec8c-19c3-847c-a315-2f70f4b1fe31@redhat.com>
 <5BBC6CB3-2DCD-4A95-90C9-7C23482F9B32@vmware.com>
 <85c72875-278f-fbab-69c9-92dc1873d407@redhat.com>
 <FC42B62F-167F-4D7D-ADC5-926B36347E82@vmware.com>
 <2aa52636-4ca7-0d47-c5bf-42408af3ea0f@redhat.com>
 <D4105FF4-5DF3-4DB5-9325-855B63CD9AAD@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <D4105FF4-5DF3-4DB5-9325-855B63CD9AAD@vmware.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 21, 2019 at 07:44:33PM +0000, Nadav Amit wrote:
> > On Aug 21, 2019, at 12:13 PM, David Hildenbrand <david@redhat.com> wrote:
> > 
> > On 21.08.19 18:34, Nadav Amit wrote:
> >>> On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote:
> >>> 
> >>> On 21.08.19 18:23, Nadav Amit wrote:
> >>>>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote:
> >>>>> 
> >>>>> On 20.08.19 11:16, Nadav Amit wrote:
> >>>>>> There is no reason to print warnings when balloon page allocation fails,
> >>>>>> as they are expected and can be handled gracefully.  Since VMware
> >>>>>> balloon now uses balloon-compaction infrastructure, and suppressed these
> >>>>>> warnings before, it is also beneficial to suppress these warnings to
> >>>>>> keep the same behavior that the balloon had before.
> >>>>> 
> >>>>> I am not sure if that's a good idea. The allocation warnings are usually
> >>>>> the only trace of "the user/admin did something bad because he/she tried
> >>>>> to inflate the balloon to an unsafe value". Believe me, I processed a
> >>>>> couple of such bugreports related to virtio-balloon and the warning were
> >>>>> very helpful for that.
> >>>> 
> >>>> Ok, so a message is needed, but does it have to be a generic frightening
> >>>> warning?
> >>>> 
> >>>> How about using __GFP_NOWARN, and if allocation do something like:
> >>>> 
> >>>> pr_warn(“Balloon memory allocation failed”);
> >>>> 
> >>>> Or even something more informative? This would surely be less intimidating
> >>>> for common users.
> >>> 
> >>> ratelimit would make sense :)
> >>> 
> >>> And yes, this would certainly be nicer.
> >> 
> >> Thanks. I will post v2 of the patch.
> > 
> > As discussed in v2, we already print a warning in virtio-balloon, so I
> > am fine with this patch.
> > 
> > Reviewed-by: David Hildenbrand <david@redhat.com>
> 
> Michael,
> 
> If it is possible to get it to 5.3, to avoid behavioral change for VMware
> balloon users, it would be great.
> 
> Thanks,
> Nadav

Just back from vacation, I'll try.