Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Sep 2019 14:01:34 +0200
From:   Thomas Bogendoerfer <tbogendoerfer@suse.de>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Evgeniy Polyakov <zbr@ioremap.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] w1: add 1-wire master driver for IP block found
 in SGI ASICs
Message-Id: <20190904140134.698aaf5f5ec204a5305c1177@suse.de>
In-Reply-To: <20190904114837.GA9153@kroah.com>
References: <20190831082623.15627-1-tbogendoerfer@suse.de>
        <20190831082623.15627-2-tbogendoerfer@suse.de>
        <20190904114837.GA9153@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 4 Sep 2019 13:48:37 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Sat, Aug 31, 2019 at 10:26:21AM +0200, Thomas Bogendoerfer wrote:
> > Starting with SGI Origin machines nearly every new SGI ASIC contains
> > an 1-Wire master. They are used for attaching One-Wire prom devices,
> > which contain information about part numbers, revision numbers,
> > serial number etc. and MAC addresses for ethernet interfaces.
> > This patch adds a master driver to support this IP block.
> > It also adds an extra field dev_id to struct w1_bus_master, which
> > could be in used in slave drivers for creating unique device names.
> > 
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> > ---
> >  drivers/w1/masters/Kconfig           |   9 +++
> >  drivers/w1/masters/Makefile          |   1 +
> >  drivers/w1/masters/sgi_w1.c          | 130 +++++++++++++++++++++++++++++++++++
> >  include/linux/platform_data/sgi-w1.h |  13 ++++
> 
> Why platform data?  I thought that was the "old way", and the "proper
> way" now is to use device tree?

this machine is old and doesn't have device tree at all.

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 247165 (AG M?nchen)
Gesch?ftsf?hrer: Felix Imend?rffer