Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp622215ybe; Wed, 4 Sep 2019 05:22:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqx801/lJzdOJ3X/urRMF0nfd/Q01fxgguFIdHhnJZJ9CM1ESJN/snBxd4qQqire8AXMyK8O X-Received: by 2002:aa7:8743:: with SMTP id g3mr17812574pfo.143.1567599743408; Wed, 04 Sep 2019 05:22:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567599743; cv=none; d=google.com; s=arc-20160816; b=kds52OpRHWdTJL1zqXaktS7aRQmAXlWAfh9W+DIm4/ZbJ+5VMj0CYAR5JY/fc4GWkA RGI7RWqhn+Z38N6jkhe5ZUSF4txL4gron/uKu8ynQUsKaM67zpm5eRNoyg+JeOkouIF5 9LhDaWtEhiAfTzvv1Yh1Yl79f55rS8Fy27/fzOBABoCZwRu1xsQqXgPAnzwOkqMh18ot cDuswXo9O4ipFg03rLe7zlCgGZvly8PcouIV/E03wZrqjIrN49ufkDeYWVMhc30QXVLV KbBHnIpsbZo+OEd8swyL38V3Y6HcmXlOCxIX+VAb8oJdnB3PVBY+maRW9lle4Y67YKkV xvNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=7diuTlWcpZ14LKOqz+UkzUoLCHxTbBgPYXaLGjC+snY=; b=OYBvUf5t3O7dspw3vPzZrzpylSZ2R7+AyMMBg2yQK5L/hQuk/7UA1VvwiO4hzDSY3R y+cseGr/TZoHzP7rUwa2cvU/o7EskbrMFoT3Gx1aQWt8s6e6aPjtIUZTpGyKoc9TmrYt HzfHjlUFTlsYGMxj2IOTkNh+H/39U7Eid5tQWeSNCBLCZCQUeoK/kijaAM8r3z5qiVBz 5NCtsuGToQ0IVDp5xwi4gyGv4N1NM8zKmcBV7Zt0y2UG0GYJjWxqbAIQVszDupJl+NOW 0HYvE2L3mdbUngQuPYOksJjYBMs6Vb1Yltxfa+i/7FsfVklSfarkCyJnLLNBnP+F8A0W Dhkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=seKruv3U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v186si16314353pgd.358.2019.09.04.05.22.05; Wed, 04 Sep 2019 05:22:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=seKruv3U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730021AbfIDMUk (ORCPT + 99 others); Wed, 4 Sep 2019 08:20:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:49420 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbfIDMUk (ORCPT ); Wed, 4 Sep 2019 08:20:40 -0400 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDC4B22DBF; Wed, 4 Sep 2019 12:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567599639; bh=hA7GVR2mWUNZnVRfBJwBG/uyYbCk89cQmzp2hZbh5pQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=seKruv3UeuC4TUAFHn6c+HNsU5IdIcStuivi2o/W9ZrpUGZda3bvpwoYSS+/SnQ2W 3CI+eJCcdf6y+HTfOzNfoxenN9NFpL0hX6TZJ6WDlraEubfwnuuD26uIE4vZYFuy2k HIK4GbG+qU5yJFddBe36r8YzeMMJjHaKUFg8OdaU= Received: by mail-wm1-f46.google.com with SMTP id k2so3061736wmj.4; Wed, 04 Sep 2019 05:20:38 -0700 (PDT) X-Gm-Message-State: APjAAAUPNUZJySro5Jdq8PKE74fPif2WO0B2Xxp2q+ttDmOvXaG54JK1 Gp25+p3h9mLiNxA3PcCOZNiDgkS12mncT35rEcs= X-Received: by 2002:a1c:9dc1:: with SMTP id g184mr4039529wme.77.1567599637242; Wed, 04 Sep 2019 05:20:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Guo Ren Date: Wed, 4 Sep 2019 20:20:25 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V6 0/3] riscv: Add perf callchain support To: Greentime Hu Cc: Mao Han , greentime.hu@sifive.com, linux-riscv@lists.infradead.org, Linux Kernel Mailing List , linux-csky@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nice job, thank you :) On Wed, Sep 4, 2019 at 3:26 PM Greentime Hu wrote: > > Mao Han =E6=96=BC 2019=E5=B9=B48=E6=9C=8829=E6=97=A5 = =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=882:57=E5=AF=AB=E9=81=93=EF=BC=9A > > > > This patch set add perf callchain(FP/DWARF) support for RISC-V. > > It comes from the csky version callchain support with some > > slight modifications. The patchset base on Linux 5.3-rc6. > > > > Changes since v5: > > - use walk_stackframe from stacktrace.c to handle > > kernel callchain unwinding(fix invalid mem access) > > > > Changes since v4: > > - Add missing PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET > > verified with extra CFLAGS(-Wall -Werror) > > > > Changes since v3: > > - Add more strict check for unwind_frame_kernel > > - update for kernel 5.3 > > > > Changes since v2: > > - fix inconsistent comment > > - force to build kernel with -fno-omit-frame-pointer if perf > > event is enabled > > > > Changes since v1: > > - simplify implementation and code convention > > > > Cc: Paul Walmsley > > Cc: Greentime Hu > > Cc: Palmer Dabbelt > > Cc: linux-riscv > > Cc: Christoph Hellwig > > Cc: Guo Ren > > > > Mao Han (3): > > riscv: Add perf callchain support > > riscv: Add support for perf registers sampling > > riscv: Add support for libdw > > > > arch/riscv/Kconfig | 2 + > > arch/riscv/Makefile | 3 + > > arch/riscv/include/uapi/asm/perf_regs.h | 42 ++++++++++++ > > arch/riscv/kernel/Makefile | 4 +- > > arch/riscv/kernel/perf_callchain.c | 95 +++++++++++++++++++= +++++++ > > arch/riscv/kernel/perf_regs.c | 44 ++++++++++++ > > arch/riscv/kernel/stacktrace.c | 2 +- > > tools/arch/riscv/include/uapi/asm/perf_regs.h | 42 ++++++++++++ > > tools/perf/Makefile.config | 6 +- > > tools/perf/arch/riscv/Build | 1 + > > tools/perf/arch/riscv/Makefile | 4 ++ > > tools/perf/arch/riscv/include/perf_regs.h | 96 +++++++++++++++++++= ++++++++ > > tools/perf/arch/riscv/util/Build | 2 + > > tools/perf/arch/riscv/util/dwarf-regs.c | 72 +++++++++++++++++++= + > > tools/perf/arch/riscv/util/unwind-libdw.c | 57 ++++++++++++++++ > > 15 files changed, 469 insertions(+), 3 deletions(-) > > create mode 100644 arch/riscv/include/uapi/asm/perf_regs.h > > create mode 100644 arch/riscv/kernel/perf_callchain.c > > create mode 100644 arch/riscv/kernel/perf_regs.c > > create mode 100644 tools/arch/riscv/include/uapi/asm/perf_regs.h > > create mode 100644 tools/perf/arch/riscv/Build > > create mode 100644 tools/perf/arch/riscv/Makefile > > create mode 100644 tools/perf/arch/riscv/include/perf_regs.h > > create mode 100644 tools/perf/arch/riscv/util/Build > > create mode 100644 tools/perf/arch/riscv/util/dwarf-regs.c > > create mode 100644 tools/perf/arch/riscv/util/unwind-libdw.c > > > > Tested-by: Greentime Hu > > I tested this patchset based on v5.3-rc6 and it can use dwarf or fp to > backtrace in Unleashed board. > > # perf record -e cpu-clock --call-graph dwarf ls -l / > total 4 > drwxr-xr-x 2 root root 0 Aug 26 2019 bin > drwxr-xr-x 5 root root 12720 Jan 1 00:00 dev > drwxr-xr-x 5 root root 0 Jan 1 00:00 etc > -rwxr-xr-x 1 root root 178 Aug 26 2019 init > drwxr-xr-x 2 root root 0 Aug 26 2019 lib > lrwxrwxrwx 1 root root 3 Aug 19 2019 lib64 -> lib > lrwxrwxrwx 1 root root 11 Aug 19 2019 linuxrc -> bin/b= usybox > drwxr-xr-x 2 root root 0 Aug 19 2019 media > drwxr-xr-x 2 root root 0 Aug 19 2019 mnt > drwxr-xr-x 2 root root 0 Aug 19 2019 opt > dr-xr-xr-x 66 root root 0 Jan 1 00:00 proc > drwx------ 3 root root 0 Jan 1 00:01 root > drwxr-xr-x 3 root root 140 Jan 1 00:00 run > drwxr-xr-x 2 root root 0 Aug 19 2019 sbin > dr-xr-xr-x 11 root root 0 Jan 1 00:00 sys > drwxrwxrwt 2 root root 60 Jan 1 00:00 tmp > drwxr-xr-x 6 root root 0 Aug 26 2019 usr > drwxr-xr-x 4 root root 0 Aug 26 2019 var > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.175 MB perf.data (21 samples) ] > > # perf record -e cpu-clock --call-graph fp ls -l / > total 4 > drwxr-xr-x 2 root root 0 Aug 26 2019 bin > drwxr-xr-x 5 root root 12720 Jan 1 00:00 dev > drwxr-xr-x 5 root root 0 Jan 1 00:00 etc > -rwxr-xr-x 1 root root 178 Aug 26 2019 init > drwxr-xr-x 2 root root 0 Aug 26 2019 lib > lrwxrwxrwx 1 root root 3 Aug 19 2019 lib64 -> lib > lrwxrwxrwx 1 root root 11 Aug 19 2019 linuxrc -> bin/b= usybox > drwxr-xr-x 2 root root 0 Aug 19 2019 media > drwxr-xr-x 2 root root 0 Aug 19 2019 mnt > drwxr-xr-x 2 root root 0 Aug 19 2019 opt > dr-xr-xr-x 66 root root 0 Jan 1 00:00 proc > drwx------ 3 root root 0 Jan 1 00:00 root > drwxr-xr-x 3 root root 140 Jan 1 00:00 run > drwxr-xr-x 2 root root 0 Aug 19 2019 sbin > dr-xr-xr-x 11 root root 0 Jan 1 00:00 sys > drwxrwxrwt 2 root root 60 Jan 1 00:00 tmp > drwxr-xr-x 6 root root 0 Aug 26 2019 usr > drwxr-xr-x 4 root root 0 Aug 26 2019 var > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.004 MB perf.data (19 samples) ] > > # perf test > 1: vmlinux symtab matches kallsyms : Skip > 2: Detect openat syscall event : FAILED! > 3: Detect openat syscall event on all cpus : FAILED! > 4: Read samples using the mmap interface : FAILED! > 5: Test data source output : Ok > 6: Parse event definition strings : FAILED! > 7: Simple expression parser : Ok > 8: PERF_RECORD_* events & perf_sample fields : FAILED! > 9: Parse perf pmu format : Ok > 10: DSO data read : Ok > 11: DSO data cache : Ok > 12: DSO data reopen : Ok > 13: Roundtrip evsel->name : Ok > 14: Parse sched tracepoints fields : Ok > 15: syscalls:sys_enter_openat event fields : FAILED! > 16: Setup struct perf_event_attr : Skip > 17: Match and link multiple hists : Ok > 18: 'import perf' in python : FAILED! > 19: Breakpoint overflow signal handler : FAILED! > 20: Breakpoint overflow sampling : FAILED! > 21: Breakpoint accounting : Skip > 22: Watchpoint : > 22.1: Read Only Watchpoint : FAILED! > 22.2: Write Only Watchpoint : FAILED! > 22.3: Read / Write Watchpoint : FAILED! > 22.4: Modify Watchpoint : FAILED! > 23: Number of exit events of a simple workload : Ok > 24: Software clock events period values : Ok > 25: Object code reading : Ok > 26: Sample parsing : Ok > 27: Use a dummy software event to keep tracking: Ok > 28: Parse with no sample_id_all bit set : Ok > 29: Filter hist entries : Ok > 30: Lookup mmap thread : Ok > 31: Share thread mg : Ok > 32: Sort output of hist entries : Ok > 33: Cumulate child hist entries : Ok > 34: Track with sched_switch : FAILED! > 35: Filter fds with revents mask in a fdarray : Ok > 36: Add fd to a fdarray, making it autogrow : Ok > 37: kmod_path__parse : Ok > 38: Thread map : Ok > 39: LLVM search and compile : > 39.1: Basic BPF llvm compile : Skip > 39.2: kbuild searching : Skip > 39.3: Compile source for BPF prologue generation: Skip > 39.4: Compile source for BPF relocation : Skip > 40: Session topology : FAILED! > 41: BPF filter : > 41.1: Basic BPF filtering : Skip > 41.2: BPF pinning : Skip > 41.3: BPF prologue generation : Skip > 41.4: BPF relocation checker : Skip > 42: Synthesize thread map : Ok > 43: Remove thread map : Ok > 44: Synthesize cpu map : Ok > 45: Synthesize stat config : Ok > 46: Synthesize stat : Ok > 47: Synthesize stat round : Ok > 48: Synthesize attr update : Ok > 49: Event times : Ok > 50: Read backward ring buffer : Skip > 51: Print cpu map : Ok > 52: Probe SDT events : Skip > 53: is_printable_array : Ok > 54: Print bitmap : Ok > 55: perf hooks : Ok > 56: builtin clang support : Skip (not compiled in) > 57: unit_number__scnprintf : Ok > 58: mem2node : Ok > 59: time utils : Ok > 60: map_groups__merge_in : Ok > # --=20 Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/