Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp709262ybe; Wed, 4 Sep 2019 06:39:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqys+LNxyYWpdBIJBJLElXZayPEenp6WMKWYXdfA6x9vYPSeefbamSc72rEe+0eEX9d9+puy X-Received: by 2002:a17:90a:d0c6:: with SMTP id y6mr5071349pjw.76.1567604388946; Wed, 04 Sep 2019 06:39:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567604388; cv=none; d=google.com; s=arc-20160816; b=07KHzpROye0OJix7TsUMp17XpvD+vaXmZO67SU2kb9Qmu5UmdiXiV//BQA7ieBgoyH ypmTIjeBdV/4atRKTwaF5GyT4JX1noFVWIKuI8/PyXKeN7urx5uoTWrpuqxAeLXxzd2s zUnGJJFZ7A2tyaGhA3PUIQgg7BjshsXFRDXTvZfN9wZd2tdDLiuhR1/i/rwoYHj+Xl2q LoTzSL+aGRoR2h7QfnMMqC/qAaYaEh9hQgh5zjrttO7koJ69Z5JgjiuGlyzG/N3Mu70H l6ZZCWMM3lQzgIu7bb9uy1e1z3hWKfNdhTjvdpuMFi5P3nBFLbkNvNNvQsou2o6zur55 Y61g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=t2AlAwm3JD11HDYgqVPXGPCvzjNZAWjeTxTJEPCwP2A=; b=DSt7gJ5rJQYNi8K4GZ/JLyY3csiHhd48XHvKN4jsKKHVvY6ydh+/hfsVkkMfFpisHs Y+CdKVq2J5n5iiMf+q3QTFBlsLUWcBPtRzAXQh+ddwYrs/gfSBWLbJEHuHLeWcoWFwvz 7NH8bLSJi5fvbxqN+ftL4wNsH2jPzcMyzmfzSalLYSdhQbTSchRG9PqOabX9EyuO+y80 n/6NaNFz5T6hIecRknv0TqyQ/6YwtF9F5VcouG+ZTkmaxot+cz9I5zijir4iGz9K5zsk xBfemldAUyytna9XTMPORUu6iafNH5gz+K4Sr5bZAHsZkNoSm5/+Qzkt3q69fcnqr5at 6hGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id fr17si2290907pjb.36.2019.09.04.06.39.32; Wed, 04 Sep 2019 06:39:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730322AbfIDNil (ORCPT + 99 others); Wed, 4 Sep 2019 09:38:41 -0400 Received: from mga18.intel.com ([134.134.136.126]:13364 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730145AbfIDNik (ORCPT ); Wed, 4 Sep 2019 09:38:40 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2019 06:38:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,467,1559545200"; d="scan'208";a="182488528" Received: from linux.intel.com ([10.54.29.200]) by fmsmga008.fm.intel.com with ESMTP; 04 Sep 2019 06:38:39 -0700 Received: from [10.249.77.74] (vramuthx-mobl1.gar.corp.intel.com [10.249.77.74]) by linux.intel.com (Postfix) with ESMTP id 514455802AF; Wed, 4 Sep 2019 06:38:37 -0700 (PDT) Subject: Re: [PATCH v3 2/2] phy: intel-lgm-sdxc: Add support for SDXC PHY To: Andy Shevchenko Cc: kishon@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, peter.harliman.liem@intel.com References: <20190904062719.37462-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20190904062719.37462-2-vadivel.muruganx.ramuthevar@linux.intel.com> <20190904123957.GM2680@smile.fi.intel.com> From: "Ramuthevar, Vadivel MuruganX" Message-ID: Date: Wed, 4 Sep 2019 21:38:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190904123957.GM2680@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy,  Thank you for the review comments . On 4/9/2019 8:39 PM, Andy Shevchenko wrote: > On Wed, Sep 04, 2019 at 02:27:19PM +0800, Ramuthevar,Vadivel MuruganX wrote: >> From: Ramuthevar Vadivel Murugan >> >> Add support for SDXC PHY on Intel's Lightning Mountain SoC. > What's the difference to eMMC PHY? > Can they share the same / similar code? eMMC and SDXC interface controller share the common driver since IP block of the vendor(SDHC-ARASAN) is same, where as PHY is different. The PHY is designed by Intel itself to support specific eMMC card and SD/SDIO card specific. e.g: PAD, CLK, driver strength..etc. IP block of the PHY  is different module for eMMC and SDXC to adapt the controllers, that is reason we have different drivers. --- With Best Regards Vadivel