Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp872698ybe; Wed, 4 Sep 2019 09:00:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRpqoWYIDv9sbCpDXrXVhwCphplu1xiwo7V+fugKeJiNMP4HCxyAAFjl59ZDGJSuBYLf7G X-Received: by 2002:a05:6a00:8c:: with SMTP id c12mr32076207pfj.200.1567612839781; Wed, 04 Sep 2019 09:00:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567612839; cv=none; d=google.com; s=arc-20160816; b=hnlu1agPUEd6WjYOYNw7cPXWV1PMWwor1W1H/tGO3Zcjy8W4Pl18ir75jyeNyFa0Ko h+oWwXJTzRfQbtRbHoqD3VYXBduZtPvA/mTKNcdBycUPwK4SKychXxOgygMNN4qZYZBx eVzyybF242wkwe3OaAymBSlDV96hXozn88h5taojE2wVyZIQwQc2qY6/MJQE2P8RFB1y 567lyRen21pSOqsRQz3q+BXQMV9hyOcO1Kx/PRR+aWxItSzuoM4lgUG8KoAVeA7FeF9p JrggmF09Pw9vpZ4/OqncosoQV2u/snruMGWAzVs7ODyZNTapLM8L38O5SUSF8Sbg+RdS vXeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cqev5nI90lwzu2qsM+gbx9Hjyd+si1udMYe50xTHCKc=; b=kGq+xFIdAvLHJ0mJr58FWdxjCbyKwrb9CUDe7GLaQcKuagKfjsgXJLHh2OnSLpW/lD oxAGa8KiMBg90f2tukC0ERBbYqnHbQUCLjHoPJpwlYt8mGhyjGyZwAr+2PPKGWgjzkMV QLIhzkr12AB2ru2aciGaIHpeqtsjFmZ/5w0vR4+yjJCT88OE3vYu7fy8uqiuFJkfLgev lxZCkWDxgzFLRxRWuQYaqUEh1j9gl8V0FJZ25Aep0o8r0cTjVQHJuk6nPA81VwYPVf5q j/qTc4MQCt6pyp1xXENvZCkJyWddD4Y/RXTxvnKjEA55flAUjTyKCW2omF7khBY4qS4/ 6Jlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eMjeTWpB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4si4708711plf.319.2019.09.04.09.00.22; Wed, 04 Sep 2019 09:00:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eMjeTWpB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732234AbfIDP7E (ORCPT + 99 others); Wed, 4 Sep 2019 11:59:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:33278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732222AbfIDP7C (ORCPT ); Wed, 4 Sep 2019 11:59:02 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5745022DBF; Wed, 4 Sep 2019 15:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567612741; bh=+PpyBe9AIAsblW3JyysaNGodo98udWJcx/rWMlVM3eg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eMjeTWpBfql8weIbqMAcRKBFa6putFfMakXzh1FtdtW7G1OfG0jyVSDiRH10lVN2z p4AI0gJhySufpFq3sDV4erlNdwFqNQIL9oQpMa2uHfFa/8Xpem32iY/pGUhVQ+rkkE SuUwBdRNMyBqUXQZlJ04xECGjj5O17CS7tleF9dk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Trond Myklebust , Jan Stancek , Naresh Kamboju , Sasha Levin , linux-nfs@vger.kernel.org Subject: [PATCH AUTOSEL 5.2 54/94] NFSv2: Fix write regression Date: Wed, 4 Sep 2019 11:56:59 -0400 Message-Id: <20190904155739.2816-54-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190904155739.2816-1-sashal@kernel.org> References: <20190904155739.2816-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit d33d4beb522987d1c305c12500796f9be3687dee ] Ensure we update the write result count on success, since the RPC call itself does not do so. Reported-by: Jan Stancek Reported-by: Naresh Kamboju Signed-off-by: Trond Myklebust Tested-by: Jan Stancek Signed-off-by: Sasha Levin --- fs/nfs/proc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index ec79d2214a78c..0f7288b94633b 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c @@ -616,8 +616,10 @@ static int nfs_proc_pgio_rpc_prepare(struct rpc_task *task, static int nfs_write_done(struct rpc_task *task, struct nfs_pgio_header *hdr) { - if (task->tk_status >= 0) + if (task->tk_status >= 0) { + hdr->res.count = hdr->args.count; nfs_writeback_update_inode(hdr); + } return 0; } -- 2.20.1