Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1023727ybe; Wed, 4 Sep 2019 11:18:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtrkoF/f3oQWtaSNCqAiBZ3zbDLmicbk2oNaElh4VixiGCNj3JM2+RuHBoD77hoHj4wUQr X-Received: by 2002:a17:90b:8ca:: with SMTP id ds10mr6277559pjb.105.1567621087397; Wed, 04 Sep 2019 11:18:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567621087; cv=none; d=google.com; s=arc-20160816; b=aMJvemJzuCDzqSsZaUBOxANd3ris1+bPu2vZJb5QFzmH8ANANbYgN4Bh0S8r5P0GqW Uq4XJtjYNnNOjSboAMV8yGoC+5kl4EVDHd6oXWwHCKpw6sigC7i7IqqaTF41/T3i8eeX 1JebPuU3x+xi89k5P9s5wLFLutwKMCpT9R0hEYkFxWuoDpd2a+YXgGLPOmD2au38mTAS 1qXSH7FLNhEWmVmVgS/GEBCEN83WJHG7E1d5kbnSQd7fbZWZu26bRYBKP3T39sQrwpiR XqvR2ZQ2TQ+5gzMsizyX9j/Oq2bgX63VGWEJlOF+9AnLJiS5MDzdS3ScdE7b7Ab9lmnB OQRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nD+9gn3LqcdvrUVdZgk1+N00GkYlfH0xAbc70gwv+o4=; b=V4tQpHI9v85wId7O/+3jrU+bffZ6HpKg9gH8X1g7BsDBREh4OvrO2H58Qv9GtTEPQa lAaNlY43LvZatMHBfTk7rGedHv0D7PW2C/bvWA2eCLoTmUufGpL/uqXPlO/qV1LNSAee nDDxIZs3njX/I8ieoVxYlofkOABzPvfH71ckGbsBasVtpwcK2uAe7F/+xTJjKpEq+mq1 0UfWC1CUQMXn0UBUpkQBue8S26ZLYaeM8dwNGMrt9f2PvVlUxTeKRldqQ4l2+D+GEcUo 8uGhlEWlWLLFUIdBXsjlZXy3ueqf/XSDOxPFaPQVofHI6iqsEeO6RTUqJfrjwBTTtRza Idfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DEbUI2kh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 59si17934896plp.331.2019.09.04.11.17.52; Wed, 04 Sep 2019 11:18:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DEbUI2kh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390688AbfIDSPQ (ORCPT + 99 others); Wed, 4 Sep 2019 14:15:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:60732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389705AbfIDSPN (ORCPT ); Wed, 4 Sep 2019 14:15:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98E9C22CF7; Wed, 4 Sep 2019 18:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567620913; bh=pNjTmQkXr2yxZMaQNAbVRnf1sMaLKyG6AAgQ8NtZhxI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DEbUI2khU4cLrnO7xq9kbryVMeRRo+MoR1hw1VxT9+M/1PpdTe2qc3hdjA+hznfXJ 2HcI4qqUB8oPqg9AfuCh10V1VlC09SnrEU6A0b4oIzfTkKRzfYdBJCVA2s7SAbdGEr 7o18QigXo2y6UWiVw2nT4r/LqAFPsVmtpqtrBduA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ville Syrjala , Maarten Lankhorst , Jani Nikula , Manasi Navare , Sasha Levin Subject: [PATCH 5.2 140/143] drm/i915/dp: Fix DSC enable code to use cpu_transcoder instead of encoder->type Date: Wed, 4 Sep 2019 19:54:43 +0200 Message-Id: <20190904175319.933659265@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190904175314.206239922@linuxfoundation.org> References: <20190904175314.206239922@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit d4c61c4a16decd8ace8660f22c81609a539fccba ] This patch fixes the intel_configure_pps_for_dsc_encoder() function to use cpu_transcoder instead of encoder->type to select the correct DSC registers that was wrongly used in the original patch for one DSC register isntance. Fixes: 7182414e2530 ("drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling") Cc: Ville Syrjala Cc: Maarten Lankhorst Cc: Jani Nikula Cc: Ville Syrjala Cc: # v5.0+ Signed-off-by: Manasi Navare Reviewed-by: Maarten Lankhorst Link: https://patchwork.freedesktop.org/patch/msgid/20190821215950.24223-1-manasi.d.navare@intel.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/i915/intel_vdsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_vdsc.c b/drivers/gpu/drm/i915/intel_vdsc.c index 3f9921ba4a769..eb978e7238c24 100644 --- a/drivers/gpu/drm/i915/intel_vdsc.c +++ b/drivers/gpu/drm/i915/intel_vdsc.c @@ -539,7 +539,7 @@ static void intel_configure_pps_for_dsc_encoder(struct intel_encoder *encoder, pps_val |= DSC_PIC_HEIGHT(vdsc_cfg->pic_height) | DSC_PIC_WIDTH(vdsc_cfg->pic_width / num_vdsc_instances); DRM_INFO("PPS2 = 0x%08x\n", pps_val); - if (encoder->type == INTEL_OUTPUT_EDP) { + if (cpu_transcoder == TRANSCODER_EDP) { I915_WRITE(DSCA_PICTURE_PARAMETER_SET_2, pps_val); /* * If 2 VDSC instances are needed, configure PPS for second -- 2.20.1