Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1034954ybe; Wed, 4 Sep 2019 11:29:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYc1YHloMcWRTGB7znK6zPwwXJ8LkqXlI7bk5+HtQHsbLcR/l59E9ElTAP7Tvowm+nD7Cn X-Received: by 2002:a63:c203:: with SMTP id b3mr36578142pgd.450.1567621780602; Wed, 04 Sep 2019 11:29:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567621780; cv=none; d=google.com; s=arc-20160816; b=ghtOZHdGsHpevyfOjLYO33jVQ0RyGpxBd+3O9WPkG8KKEjSwYfZ8cEZtgNnBXyRP3v oUm2rLed2/gV2NFKHNRM8C+YHs6nEb1dEaWIx+bLL/oimv6FTqJ65AvvPsR88GajiUk7 EfC8FmiBVWq6U9z+/y6ERtGlxW0uztRErpIMKKmaU35XB4xsKKmH6RWYsWw9N8YxBzSb kbZ/9h+Wei6xycuFJo1rMPgCbhOntpQLrPVfH2i1LbPSBrOhWS1i2Jrr9auvfFLs43Jh 5BH6Oe0craRJMtuNm7NXofFhpv8+SD6yNxDSzleETC+Zu0k21JKeXFw6N59qK+GjkdmR K9qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MQKdcvRiYkS/cwbwPhPB79D/ADcdH6vuBs31VuFkhnk=; b=mY13KTXgVJ7ma31oM6Xt/ZudT70cXzTxSDCfgCKZS7XkH4WanZrxTc2GainaGzzDNp a3x9pY+Ve+m0l3YZJt4I9HX3nb51eXZgY5LZS0M/vQg17P3zxpKKl2F5wJ3SMnuPhmR8 95vexk96dzM2XJ/y7Ej6qXmUr4Jk65Q8s1teQaq46igjQQJOhHbleZ3Z2r2NGPqkhNTC Fdygoc75VO8f4nmCN4N3q/I8s9ap7b7fKuyUxlR/2xtq2gijHgjZdmuHhnYObH20RChy 5uA15oW4LpGJ0nvIXRzb8ABiKH2KHAiMasxSosGAHbqpqJI3NlKKbsG099TS0F1GtnRF kjbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="SOVZu1/0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7si9124895pfr.4.2019.09.04.11.29.25; Wed, 04 Sep 2019 11:29:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="SOVZu1/0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733267AbfIDR4Q (ORCPT + 99 others); Wed, 4 Sep 2019 13:56:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:33436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733211AbfIDR4N (ORCPT ); Wed, 4 Sep 2019 13:56:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D830323400; Wed, 4 Sep 2019 17:56:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567619772; bh=YaezAtlfkEaTi5ezWg9Y7/KVHwZlyo5nraWPbkLVsaE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SOVZu1/0h9DHMqQ88NdbSeXSVmjB44VgoH7l+uOdqcqd9aZOi78k/hTEWf7IbC6Sp 3may/LmMhDBHZOfM0Uo9C/6H88xpOcKNuQil/jS0eZSLAoNL3cQkCSCen1YHWGcVpj QbWbe5YEYw++Ps29au9QRXNtXv8qApHYAM11y3gU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Neil MacLeod , Thomas Gleixner , John Hubbard Subject: [PATCH 4.4 29/77] x86/boot: Fix boot regression caused by bootparam sanitizing Date: Wed, 4 Sep 2019 19:53:16 +0200 Message-Id: <20190904175306.362034308@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190904175303.317468926@linuxfoundation.org> References: <20190904175303.317468926@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: John Hubbard commit 7846f58fba964af7cb8cf77d4d13c33254725211 upstream. commit a90118c445cc ("x86/boot: Save fields explicitly, zero out everything else") had two errors: * It preserved boot_params.acpi_rsdp_addr, and * It failed to preserve boot_params.hdr Therefore, zero out acpi_rsdp_addr, and preserve hdr. Fixes: a90118c445cc ("x86/boot: Save fields explicitly, zero out everything else") Reported-by: Neil MacLeod Suggested-by: Thomas Gleixner Signed-off-by: John Hubbard Signed-off-by: Thomas Gleixner Tested-by: Neil MacLeod Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/20190821192513.20126-1-jhubbard@nvidia.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/bootparam_utils.h | 1 + 1 file changed, 1 insertion(+) --- a/arch/x86/include/asm/bootparam_utils.h +++ b/arch/x86/include/asm/bootparam_utils.h @@ -70,6 +70,7 @@ static void sanitize_boot_params(struct BOOT_PARAM_PRESERVE(eddbuf_entries), BOOT_PARAM_PRESERVE(edd_mbr_sig_buf_entries), BOOT_PARAM_PRESERVE(edd_mbr_sig_buffer), + BOOT_PARAM_PRESERVE(hdr), BOOT_PARAM_PRESERVE(eddbuf), };