Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <ab957f98a62390dbc603632704c60d39596095c1.camel@perches.com>
Subject: Re: [PATCH] media: siano: Use the correct style for SPDX License
 Identifier
From:   Joe Perches <joe@perches.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Nishad Kamdar <nishadkamdar@gmail.com>,
        Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 04 Sep 2019 12:26:45 -0700
In-Reply-To: <20190904160010.4532c3f5@coco.lan>
References: <20190831151147.GA7082@nishad>
         <20190904153432.7fb54f02@coco.lan> <20190904183608.GA495@kroah.com>
         <20190904160010.4532c3f5@coco.lan>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.32.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2019-09-04 at 16:00 -0300, Mauro Carvalho Chehab wrote:
> With Python, you can't even use the second line, as it is reserved
> for charset encoding. 
> 
> So, realistically, the SPDX header could be up to the third line of
> a given file.
> 
> Besides that, I vaguely remember some discussions we had, back on the
> days SPDX was introduced, envolving Thomas, Linus and others. My 
> understanding for such discussions is that something like this:
> 
> /*
>  * SPDX-License-Identifier: GPL-2.0+
>  *
>  * some other notes about the file
>  */
> 
> Would be acceptable, as the first line of the comment (with is at
> the beginning of the file) is the SPDX tag.

Using the 2nd line of a .[ch] file does not follow the
documented mechanisms.

Documentation/process/license-rules.rst-1. Placement:
Documentation/process/license-rules.rst-
Documentation/process/license-rules.rst-   The SPDX license identifier in kernel files shall be added at the first
Documentation/process/license-rules.rst:   possible line in a file which can contain a comment.  For the majority
Documentation/process/license-rules.rst:   of files this is the first line, except for scripts which require the
Documentation/process/license-rules.rst:   '#!PATH_TO_INTERPRETER' in the first line.  For those scripts the SPDX
Documentation/process/license-rules.rst:   identifier goes into the second line.