Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 05 Sep 2019 01:19:27 +0530
User-Agent: K-9 Mail for Android
In-Reply-To: <20190904130457.24744-1-yuehaibing@huawei.com>
References: <20190904130457.24744-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code
To:     YueHaibing <yuehaibing@huawei.com>, alim.akhtar@samsung.com,
        avri.altman@wdc.com, pedrom.sousa@synopsys.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, liwei213@huawei.com,
        dimitrysh@google.com, kjlu@umn.edu, tglx@linutronix.de,
        yuehaibing@huawei.com, stanley.chu@mediatek.com, arnd@arndb.de
CC:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Message-ID: <56F1F139-26BD-42D6-8C24-118DEC0D0B97@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4 September 2019 6:34:57 PM IST, YueHaibing <yuehaibing@huawei=2Ecom> w=
rote:
>Use devm_platform_ioremap_resource() to simplify the code a bit=2E
>This is detected by coccinelle=2E
>
>Reported-by: Hulk Robot <hulkci@huawei=2Ecom>
>Signed-off-by: YueHaibing <yuehaibing@huawei=2Ecom>

Acked-by: Manivannan Sadhasivam <manivannan=2Esadhasivam@linaro=2Eorg>

Thanks,=20
Mani
>---
> drivers/scsi/ufs/ufs-hisi=2Ec | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufs-hisi=2Ec b/drivers/scsi/ufs/ufs-hisi=2E=
c
>index f4d1dca=2E=2E6bbb167 100644
>--- a/drivers/scsi/ufs/ufs-hisi=2Ec
>+++ b/drivers/scsi/ufs/ufs-hisi=2Ec
>@@ -447,13 +447,11 @@ static int ufs_hisi_resume(struct ufs_hba *hba,
>enum ufs_pm_op pm_op)
>=20
> static int ufs_hisi_get_resource(struct ufs_hisi_host *host)
> {
>-	struct resource *mem_res;
> 	struct device *dev =3D host->hba->dev;
> 	struct platform_device *pdev =3D to_platform_device(dev);
>=20
> 	/* get resource of ufs sys ctrl */
>-	mem_res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1);
>-	host->ufs_sys_ctrl =3D devm_ioremap_resource(dev, mem_res);
>+	host->ufs_sys_ctrl =3D devm_platform_ioremap_resource(pdev, 1);
> 	if (IS_ERR(host->ufs_sys_ctrl))
> 		return PTR_ERR(host->ufs_sys_ctrl);
>=20

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E