Message-ID: <43AAEF6E.47CCEFE0@tv-sign.ru>
Date: Thu, 22 Dec 2005 21:24:46 +0300
From: Oleg Nesterov <oleg@tv-sign.ru>
MIME-Version: 1.0
To: Daniel Walker <dwalker@mvista.com>
Cc: linux-kernel@vger.kernel.org, inaky.perez-gonzalez@intel.com,
       tglx@linutronix.de, mingo@elte.hu
Subject: Re: [PATCH 02/02] RT: plist namespace cleanup
References: <1135202230.22970.15.camel@localhost.localdomain>
		 <43AAB3C8.DB304856@tv-sign.ru> <1135270381.3696.2.camel@localhost.localdomain>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1065
Lines: 32

Daniel Walker wrote:
> 
> On Thu, 2005-12-22 at 17:10 +0300, Oleg Nesterov wrote:
> > Daniel Walker wrote:
> > >
> > >         Make the plist namespace consistent.
> >
> > I think plist_head is much better than pl_head.
> >
> > However I think plist_empty/plist_unhashed is more accurate
> > than plist_head_empty/plist_node_empty, but I am rather
> > agnostic to naming.
> 
> unhashed seems very meaningless . We're not hashing anything.

Still we already have hlist_empty/hlist_unhashed

> > Daniel, it would be great if you can check that kernel/rt.o
> > was not changed after rename (as it should be).
> 
> I didn't check, but I made no code changes so it should be any
> different.

That is why I asked. It is very easy to make a mistake by accident
while doing trivial changes, but it is not easy to notice.

Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/