Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp77736ybe; Wed, 4 Sep 2019 15:28:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzhlTqmXNB5a0+ACRiw/qOvrUcvtSbpbixkK4NNIvConiQCQvEHmquDnjS4bGVGuU8+bYBp X-Received: by 2002:a17:90a:de11:: with SMTP id m17mr530526pjv.38.1567636110059; Wed, 04 Sep 2019 15:28:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567636110; cv=none; d=google.com; s=arc-20160816; b=bFqH+yo92xyRLuKGlSVKuwzug5o2rYvbCJgnpmrkKLm15MiHkn6u+k7pOy0EmUDgn4 2VidfLWpmoLvjdoITw23Tr7BsP5/NzfEQ1hG6TNB6L44sB2pszF93QXaQhak49GDlFSA bd/UETSbe5wMl/Ma262oU7Q+RSicpYNJi+/rskfkcpLSSV+0r6hZrxdlqKV1FETTQl3l us8YhLdlSvQWu0DNct7970wLCLUOvuUhXEaBoMCF0nRC8Lq2B5xoJtNMSI+/xnodiOmi qFQlhK+qqVPp2J5R5Rbwtsevpc9mV7Q472yjurnDvJCf3MskuZTiL00EXAfInm6chmiC i3oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=WktHCMlysHg3tK2dKyD01s612iWxCfJklLqhiYA7z/o=; b=jW50YwhbdwvRdiETkjC3XtnrQAl3KNaBj26n99LxmSez6JUKeitlfJW5bf8q3SAs3j x+n/mcqriGtIXCldoarwpYWX9FkrkDdlp6OrwSb+slDSIeJByveXyPthsxzPWpgSvXFo BZ9FGpB2oJSeEEO0Mt9FFbmEmI2Qy9JwX+Kq+xO4nSSRPVmcout3DuVEaHWo08jI/Z5u eA+2VR/bOGrlxPGq1Z2gYCV8SrjvmTWkZLwQIisgu6m/wfIJ/2oqvJD7ZfmBtI43jnFb PwQdcHVRtlgAVGTGabHslag5HdOIxkY/CSHxzD56m5nB/CTY6sfU5i/t5elw0TGQLUWj us4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si177458plp.421.2019.09.04.15.28.14; Wed, 04 Sep 2019 15:28:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730552AbfIDW0u (ORCPT + 99 others); Wed, 4 Sep 2019 18:26:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38702 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbfIDW0t (ORCPT ); Wed, 4 Sep 2019 18:26:49 -0400 Received: from localhost (unknown [62.21.130.100]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8271615286006; Wed, 4 Sep 2019 15:26:48 -0700 (PDT) Date: Wed, 04 Sep 2019 15:26:46 -0700 (PDT) Message-Id: <20190904.152646.1973211125417119901.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] r8152: modify rtl8152_set_speed function From: David Miller In-Reply-To: <1394712342-15778-326-Taiwan-albertk@realtek.com> References: <1394712342-15778-326-Taiwan-albertk@realtek.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Sep 2019 15:26:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang Date: Mon, 2 Sep 2019 19:52:28 +0800 > First, for AUTONEG_DISABLE, we only need to modify MII_BMCR. > > Second, add advertising parameter for rtl8152_set_speed(). Add > RTL_ADVERTISED_xxx for advertising parameter of rtl8152_set_speed(). > Then, the advertising settings from ethtool could be saved. > > Signed-off-by: Hayes Wang Applied.