Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp81466ybe; Wed, 4 Sep 2019 15:32:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrE+RNvCjZ/+vAdCMFw0kYE2Sjb+dlEefAZQUk5hJfhY2B6nshsLR6woEw6NgZpvO/hHWL X-Received: by 2002:a62:2603:: with SMTP id m3mr11873pfm.163.1567636355901; Wed, 04 Sep 2019 15:32:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567636355; cv=none; d=google.com; s=arc-20160816; b=T2c1BDf8FQLTFF8z7EOZZL+E5fDGYhoTIdHb2TVoZOQY8czKkPL+8HpB0q2A2Q0Pub uz4ZC7EyEgFKeOraCpoWBjq2vbFohVbloloimQUnrCWSDE3NNLmiOz0u4+srRZGRqvc/ IHyCuHRWzBY+exsMm5YGgC7SIq83dnACeQ6otzen+LOMrXGzXYQMmPHCm9lye2zA3Ssl fnR9KAgPxBoaXp7nqpRmmVz3ThUBqmncW2Ax1cZ1CLWSUpYLwfkI0Xg758I6dzsW1e4Z nzjMylx6a0m8utZKIehKhLXwOGDVpKCOfUM2HNr0ZQxXriUE+hFZ942gdo7zR6oIeiCM ZjRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:cc:to:references:in-reply-to:from:organization; bh=OxnQiYJcXMXDqt/MRKto9Xvnl310U3kXnDCTQltUflo=; b=MzIGDqvj02h9jL83PGR2T0qV42P2zviI6agz7dmB3har2dtDMtPAHmV/bgaMM/8dMH CICq+FfRC1ieP/Hd7NJZHHDkaERVgtpMlGx6FJ3cjt9L1fBmCdL+vW7oeKdbidLv7CUc 0sfooq0Y3tkoT5oBftF80pppXl8YcfIgWDu6vRF/aN/ujf66whB6QtU2wjDBE6lVxXLO 5a32/7Na0oU88UNn1UtKBKVsa2iEGJuyNV5Hkxk9KqUxgalaKngGIeHFI69Q1jkV6m7k Qmx5XKbJePVPedIbMIqX/3ijj5mP/cAOJCd5vQFqpSe61nybEVcZSmXT2sK1EFQdfBto +EIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si54355pgn.290.2019.09.04.15.32.18; Wed, 04 Sep 2019 15:32:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730498AbfIDWb3 (ORCPT + 99 others); Wed, 4 Sep 2019 18:31:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33580 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729919AbfIDWb2 (ORCPT ); Wed, 4 Sep 2019 18:31:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7774A10277E2; Wed, 4 Sep 2019 22:31:27 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-255.rdu2.redhat.com [10.10.120.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2332A1001956; Wed, 4 Sep 2019 22:31:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-11-cyphar@cyphar.com> <20190904214856.vnvom7h5xontvngq@yavin.dot.cyphar.com> To: Linus Torvalds cc: Aleksa Sarai Cc: Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Ingo Molnar , Peter Zijlstra , Christian Brauner , Jann Horn , Kees Cook , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Rasmus Villemoes , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Aleksa Sarai , Linux Containers , alpha , Linux API , linux-arch , Linux ARM , linux-fsdevel , linux-ia64@vger.kernel.org, Linux List Kernel Mailing , "open list:KERNEL SELFTEST FRAMEWORK" , linux-m68k , linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390 , Linux-sh list , linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v12 10/12] namei: aggressively check for nd->root escape on ".." resolution MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20591.1567636276.1@warthog.procyon.org.uk> Date: Wed, 04 Sep 2019 23:31:16 +0100 Message-ID: <20592.1567636276@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Wed, 04 Sep 2019 22:31:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > Hinting to userspace to do a retry (with -EAGAIN as you mention in your > > other mail) wouldn't be a bad thing at all, though you'd almost > > certainly get quite a few spurious -EAGAINs -- &{mount,rename}_lock are > > global for the entire machine, after all. > > I'd hope that we have some future (possibly very long-term) > alternative that is not quite system-global, but yes, right now they > are. It ought to be reasonably easy to make them per-sb at least, I think. We don't allow cross-super rename, right? David