Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp573031ybe; Thu, 5 Sep 2019 02:28:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzaIfvn5WR5en9rYlBYH8f3A/w46gSTtfhOyaLs4l1x69hg25Faum3UE4nDxuw5rcumI2O X-Received: by 2002:a65:5786:: with SMTP id b6mr2257939pgr.236.1567675705539; Thu, 05 Sep 2019 02:28:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567675705; cv=none; d=google.com; s=arc-20160816; b=zAZI2d/BCiFlP7DGsiQVa0gnYaAF102LYy+t692O6Ju5kiaI3ZkD1xoBePZc78pONG 4b8WpB76WW7vx6TJiBXsakDTn5kU86Snob88sMZZbgH8RZueD1wR99ITD+g6cOL0ysL8 vRGG5a8E54UiTjJjH9zKKxl7yZHGnMKaMi2XCEW16XyKEnCzlEu5jmQexi9/l1dT+jJN 4cM52ObSx053ueaL+U5Tfe1ONe1DNrZFzvMUF/54g/+IEBOZkhGFglAZKI4Im8uNzrZk /JVPAXZkKFddN0ftUoTUbw7+XNEKrFBxnzYu+ZDDFn9QeNi6XJmCwGKBpGDYNdUfcLju rcsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=BNUhBxF1OnG3d3ID43Jl2Sra4Jf1K5JNUVXSe0J/Mmo=; b=v3xZkSMEydsLTBeMfWmShkdRgWfqFWJ8Z/XxwfQRVeAtpslu4OOy9yEw7fiAq+asvN PdFO33KyZKZ0otuUiWTC8k3Rv1A+zFRl2vuBd0G6b0+NRttIATgtgsFZEaJ/VcBo0CtQ BVgrPj6iFniy0CfW71xxEoiqMjyhS3Bkm+zOeK+u9QQZ8EiGIqqGak//JHEkyaLFhCap DlzHpTA8cRozL/mVewus2sSj5BF+Bz1GsWNMM+2gHQKXBUCUAIxy6oTtCf9uk/KnK6kw 1tjZPAG+yM30MtXWMkd2+UFISwdDFjtwF3wXEsXgYbddrDCPBu89J6J8yp2m8mkNQ0kQ aSFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FsniQefV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s65si1567605pjc.103.2019.09.05.02.28.09; Thu, 05 Sep 2019 02:28:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FsniQefV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732415AbfIEILI (ORCPT + 99 others); Thu, 5 Sep 2019 04:11:08 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43762 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725290AbfIEILI (ORCPT ); Thu, 5 Sep 2019 04:11:08 -0400 Received: by mail-pg1-f196.google.com with SMTP id u72so968422pgb.10; Thu, 05 Sep 2019 01:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BNUhBxF1OnG3d3ID43Jl2Sra4Jf1K5JNUVXSe0J/Mmo=; b=FsniQefV8YjuNc/PRrZO7rOT/9G0ax8+aLc2Sz/tUwIKjH+DrNsgTNPIdCNssllbf1 yTsw2jCCl+nhi3JG+3OiKUJbn9m3OqZzU/MwtpGG7EvVTeby+PTM1a4kWl+pAl/W8p2f QW3A2gnfv/hpd5csElAMUYftBSWWIMgYAbyA8tas18mDueWBGlE+8y8yMlS7K97UJz1e FdGd63Y59wGv26usW5cD/I64bNqERDONTXMRb/TQ1dMOR3neAW0ou+hw7gmHuZ/jLN3R Yq6qr2hqq64hFguW6qK+LgttRPvNo0jBVjB5hpdOXr7pVzj2BUERpVvhbtWwaa3rb9Bu 0X5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNUhBxF1OnG3d3ID43Jl2Sra4Jf1K5JNUVXSe0J/Mmo=; b=TH+4o0+FR28jprocDOAgxdStGWwYI4ivFWyD9jEbgXJSqK/26fbtj+x1cpC51KPqf5 4BygmquP+5crbeqBq7wbVSV9zOCCP2mnPKGGHDcuBMzHSn0/ZJJg5mwOcUsFPPA+qIJg znozsFSRIbshEMeF9QTY9Tu8Hqy++Cw2il0jSdnqqp3O/msHAWRaJ0kNMcT9Tmn7/q8G /4TvZzJtdjul/KxSkoVIOiXvoyqmWMsfZwcHqKJURhidViw9Mf2d7gGP0SLRY4oP7+tJ /ow4wSMJ18pA9mc1diAxCajMA1D/610joibQO7e4Sb9QRdavgXeflmzTqc7Nd4QNmUvl fEsg== X-Gm-Message-State: APjAAAWty45o2FqkvW5k+m1tq+JCuS0f7XFROzp36srUBkbO3sgbupsg UqQ5Ym7uCHPazLoTmCKX47sQ2HNVCHwK/vdg8WA= X-Received: by 2002:a17:90a:338b:: with SMTP id n11mr2570783pjb.132.1567671067543; Thu, 05 Sep 2019 01:11:07 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> <20190904061245.30770-3-rashmica.g@gmail.com> <1ca6ffddd2452e218ef19ea84ac6c6277e1a9725.camel@gmail.com> In-Reply-To: <1ca6ffddd2452e218ef19ea84ac6c6277e1a9725.camel@gmail.com> From: Andy Shevchenko Date: Thu, 5 Sep 2019 11:10:55 +0300 Message-ID: Subject: Re: [PATCH 3/4] gpio: Add in ast2600 details to Aspeed driver To: Rashmica Gupta Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , linux-arm Mailing List , linux-aspeed@lists.ozlabs.org, Linux Kernel Mailing List , Joel Stanley , Andrew Jeffery Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 5, 2019 at 2:34 AM Rashmica Gupta wrote:> > On Wed, 2019-09-04 at 19:30 +0300, Andy Shevchenko wrote: > Perhaps this and your other comments below would be best addressed in > an additional cleanup patch? This patch follows the formatting of the > existing code and it's not very clean to differ from that or to change > the formatting of the current code in this patch. OK. -- With Best Regards, Andy Shevchenko