Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp641373ybe; Thu, 5 Sep 2019 03:41:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGVHBpAb69D3d21Q6FaeKsDwts/pdOPHOHj9sCy4USn1xQLBXvObC1R4x0hUZFjDWaXlvu X-Received: by 2002:a65:4786:: with SMTP id e6mr2470922pgs.448.1567680076252; Thu, 05 Sep 2019 03:41:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567680076; cv=none; d=google.com; s=arc-20160816; b=a5cl1Sts8xMl0Wi2hdeSXorw1ntkq91bEuLaCWGFAwZ9M5/W2kW6GzDyCBf5Trs619 Rho4GuFvlvXhEB4dn2AoDCVD8wLMuw3Moh93rVAdBl1lbEFoFgmQy9LV+/GcHAlOBFU3 FblTh87jVh7VGcgjE48b7Qln67pLiC184dhT3vRS0af+lR5S2SdZ58kRfxsAKlO7iy2L kwN0/Wif70Fx43rBN3WZ7QjnDNnj46N7pQi6zLMexre+9loix5+I9EzZT0TIrOORAiPs f4TNIu1VVA2xHGjvRDtPYAbT2kcwERqunxIfdQZA5HqiC39BG3vWqY/vAypZlAGvoiBW W1HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=lZYcA+X2SCHGj/vFSv/w4oxvzfBhx3uD4j4ruIUUVDw=; b=UTt5IS8r4XMGJ7v41BW00ZVMqW7cABNzu7i6f6WWtuIyY53ED/0SsB/hfS0+Jl2q/w hOC+eYF1CX9BTE80pcXakNnGsMH1zeVP1FpaVMWeu1EHNHT1yDm+7GRJtViHnsGvTilV KSjeC2dzmRQzQMLstkDJ1xHQ5tmUiINom/Pur+xjdyRMRWy8OFADQGgKTr+/HXwX+nEy +66/INMZ5Z/iuv0ppCu0yv5n72kOgNEkjHpmGP+8ynIdLcGvo9o9ySaiXczzRwP5+3TR GwAadHyYBKrQ3j6oN28eXavN/sY6coUj8VHAJHQS5YcL4vsmT3DzTA4yElTUC7f8V3yL +BCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 21si1375646pgk.492.2019.09.05.03.41.00; Thu, 05 Sep 2019 03:41:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387823AbfIEKQK (ORCPT + 99 others); Thu, 5 Sep 2019 06:16:10 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732834AbfIEKQJ (ORCPT ); Thu, 5 Sep 2019 06:16:09 -0400 Received: from localhost (unknown [89.248.140.11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 86284153878FA; Thu, 5 Sep 2019 03:16:08 -0700 (PDT) Date: Thu, 05 Sep 2019 12:16:07 +0200 (CEST) Message-Id: <20190905.121607.544007284666165538.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] r8152: adjust the settings of ups flags From: David Miller In-Reply-To: <1394712342-15778-327-Taiwan-albertk@realtek.com> References: <1394712342-15778-327-Taiwan-albertk@realtek.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Sep 2019 03:16:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang Date: Wed, 4 Sep 2019 17:34:38 +0800 > The UPS feature only works for runtime suspend, so UPS flags only > need to be set before enabling runtime suspend. Therefore, I create > a struct to record relative information, and use it before runtime > suspend. > > All chips could record such information, even though not all of > them support the feature of UPS. Then, some functions could be > combined. > > Signed-off-by: Hayes Wang This does not apply cleanly to net-next, please respin.