Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp678445ybe; Thu, 5 Sep 2019 04:19:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+e2u6NRtBrA4C3e+TIIbVSAjZJsGTNfTQP0svuA2oujrjDLbpnJmPxGx9H2RPYREXJ3n8 X-Received: by 2002:a65:654d:: with SMTP id a13mr2631117pgw.196.1567682358269; Thu, 05 Sep 2019 04:19:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567682358; cv=none; d=google.com; s=arc-20160816; b=seq+R4HZtBKjhmYVH8y3cMrW8if7LSVlpdy029bW5mNEtSUoStstXBDUfNwQKc1Dhg CMZM+jkem6wObf4cTez+SY4soSqn/ox2l/vegjcP8OgFIMRRXV/VzSUj4xINeEX34XAo WfPMUyHacXFsihAu1E5JdFqW0lZpxnPv0Vs7VhGMKle8+BGtg2QOPywxlg+5DBsexzcb /r/hQY2HQ2z8nQZDd4NO+GvV9zKEN7aPJsWuzbNuyMauEQO6HwS6/kwY5vlYlbQCMT8Y FGhDoTYyMXkXtmUX2gzTfpcwEig8WVWJQ3AtN1t9D9R/cpNbzhA9O1FEBXFq2usVfhqz r/wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id; bh=kUe0YGnW/GZLbR+eOIL4QHpnAoB4h9cSd149Fb0nPrE=; b=yKrhy6D+43KFiC0BQLSoebl/iPP/qoawtww4LoMo97SLE+AGupTRk/hqtHPygTs007 eRWzMds/Li1wz6i5PeY+sWrVwuqhCqOR9+mfRF/S10sUAW3kitLy0cMwQWN7LThg1pEI ilkKtlhvSKNDTAcIP7KsGuz0FnOrZkbK0qVJOc4Kg5btfOfa44UDkTCDBOwLNOHlGGM4 111K/JbyOJpmdSIrgehrA1+vjoIe9GpYPg+IcFsa06Pixc1FF3SAhsonQGKHtI2w9X4L FOXZaQytIV12qJQp5C8iWW/sa9dBkgMahVnGgKxG5U3oQtXV0FjEeqisOUq5OABsWlNI mvCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 11si1706787pla.399.2019.09.05.04.19.02; Thu, 05 Sep 2019 04:19:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732441AbfIEIqz (ORCPT + 99 others); Thu, 5 Sep 2019 04:46:55 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6681 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730939AbfIEIqy (ORCPT ); Thu, 5 Sep 2019 04:46:54 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D6B0097C7232F14FB686; Thu, 5 Sep 2019 16:46:52 +0800 (CST) Received: from [127.0.0.1] (10.177.29.68) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.439.0; Thu, 5 Sep 2019 16:46:51 +0800 Message-ID: <5D70CB7A.8040307@huawei.com> Date: Thu, 5 Sep 2019 16:46:50 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Markus Elfring CC: , , LKML , Subject: Re: drm/amdgpu: remove the redundant null check References: <1567491305-18320-1-git-send-email-zhongjiang@huawei.com> <62b33279-9ca9-5970-5336-a8511ce54197@web.de> <5D70A196.3020106@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/9/5 16:38, Markus Elfring wrote: >>> Were any source code analysis tools involved for finding >>> these update candidates? >> With the help of Coccinelle. You can find out some example in scripts/coccinelle/. > Thanks for such background information. > Was the script “ifnullfree.cocci” applied here? Yep > Will it be helpful to add attribution for such tools > to any more descriptions in your patches? Sometimes, I will add the description in my patches. Not always. Thanks, zhong jiang > Regards, > Markus > > . >