Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <f65bf8e7bc3234358d5956f94e3b4df81bc204e6.camel@perches.com>
Subject: Re: [PATCH] media: siano: Use the correct style for SPDX License
 Identifier
From:   Joe Perches <joe@perches.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Nishad Kamdar <nishadkamdar@gmail.com>,
        Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 05 Sep 2019 02:28:05 -0700
In-Reply-To: <20190905055614.7958918b@coco.lan>
References: <20190831151147.GA7082@nishad>
         <20190904153432.7fb54f02@coco.lan> <20190904183608.GA495@kroah.com>
         <20190904160010.4532c3f5@coco.lan> <20190905055430.GA23826@kroah.com>
         <20190905055614.7958918b@coco.lan>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.32.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-09-05 at 05:56 -0300, Mauro Carvalho Chehab wrote:
> I'll accept
> this patch and keep such rule in mind for next SPDX changes.
> 
> Anyway, with regards to script, we need to change the rules in order to
> allow adding SPDX for python scripts, as otherwise the addition of SPDX
> headers may cause regressions.

Not really.

$ git grep -n '^# SPDX-License-Identifier' -- '*.py' | wc -l
62
$ git grep -n '^# SPDX-License-Identifier' -- '*.py' | \
  cut -f2 -d: | sort | uniq -c
     32 1
     27 2
      3 3
$ git grep -n '^# SPDX-License-Identifier' -- '*.py' | \
  cut -f1 -d: | xargs ./scripts/spdxcheck.py --verbose

License files:               14
Exception files:              2
License IDs                  19
Exception IDs                 2

Files checked:               62
Lines checked:               95
Files with SPDX:             62
Files with errors:            0