Date: Thu, 22 Dec 2005 12:01:11 -0800
From: Greg KH <greg@kroah.com>
To: Mark Maule <maule@sgi.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
       Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions
Message-ID: <20051222200111.GB14332@kroah.com>
References: <20051222171616.8240.37671.12506@lnx-maule.americas.sgi.com> <20051222171626.8240.40685.41154@lnx-maule.americas.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051222171626.8240.40685.41154@lnx-maule.americas.sgi.com>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 35

On Thu, Dec 22, 2005 at 11:15:19AM -0600, Mark Maule wrote:
> --- msi.orig/drivers/pci/msi.c	2005-12-21 16:10:32.838675711 -0600
> +++ msi/drivers/pci/msi.c	2005-12-21 18:55:05.020985381 -0600
> @@ -35,7 +35,7 @@
>  
>  #ifndef CONFIG_X86_IO_APIC
>  int vector_irq[NR_VECTORS] = { [0 ... NR_VECTORS - 1] = -1};
> -u8 irq_vector[NR_IRQ_VECTORS] = { FIRST_DEVICE_VECTOR , 0 };
> +u8 irq_vector[NR_IRQ_VECTORS] = { [0 ... NR_IRQ_VECTORS - 1 ] = 0 };

As previously mentioned, you don't have to initilize this to 0.

>  #endif
>  
>  static struct msi_ops *msi_ops;
> @@ -377,6 +377,11 @@
>  		printk(KERN_WARNING "PCI: MSI cache init failed\n");
>  		return status;
>  	}
> +
> +#ifndef CONFIG_X86_IO_APIC
> +	irq_vector[0] = FIRST_DEVICE_VECTOR;
> +#endif

Why do this here, what's wrong with the original code above in the
static declaration?  Or am I missing some logic change somewhere?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/