Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp776180ybe; Thu, 5 Sep 2019 05:55:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5cGEOaCz2AeJFFVc2tcNIDyAjEfL9v3WJAQ6HtgES9J3+W0pL0X47cYnTCWooeaKjbPQ8 X-Received: by 2002:a62:115:: with SMTP id 21mr3760636pfb.110.1567688112677; Thu, 05 Sep 2019 05:55:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567688112; cv=none; d=google.com; s=arc-20160816; b=nAyHE6d4ZPU6BrW+EXIua5EqgI97nNQtxfaLIzAcBdCAIjoosA48abQEvDeAb04Vg5 i2E9df1Kfj0GklyMgt/6P+gbs1TkgApL3RdNSOx6Dk14X6LbBeYnX+huDCg72br9Oq/Q y1xBvjMc76z2388Khju2qVn3I8xbnrlCm5hMsro5i6LBa00XkK/NbgBb7cgRtXn9N2+S 9Z6BKax1Vr9rM+/JbdOlXgreiUemJ7pV2sUDZ63bJP9xW8ZWkHqiexrhJG4WwP8Fs9Cu aJa2RzGnhxybp2+XKmVrwamVppp9eOdLxVf+LCOkja6YBaCWQxG7h8n7fJEgMW8aCC6p Rqjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=wvdqDnxFBX+4h6G04JGrStBn6NnqRdj9eLyj2U2UQE4=; b=OceNm6jvaFmJxtdwRPELHVPXHPKU9PpNtqYcUewURpzR3hwr7WyGG4Ib0WApbHwgtQ lt4Fsd2aCRy06vgCbs1q0HvSlJLgyGbFAeeZ/Sosh6NYxxEiDovf62yox78SmijvgYpd Yr7EhSz/P8JfMqBF6/v6hYP8aSb7f2AjBP231aEkT/OD2NUNzi3R0SnL/lE7P1u58+RB kd9LeKyZMW2sGd1OUzad9D16CEksR8HbvF2IibcIeHwl4ZBNelq8hmFytR78o14pVoiK TumE0C0Qy+tt82pB8seObv5HBrQJGispobnw5Bedztvosc9lVsVzNB/8QX27nqoYOWW/ tlZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h31si800936pgb.67.2019.09.05.05.54.56; Thu, 05 Sep 2019 05:55:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387817AbfIEKlq (ORCPT + 99 others); Thu, 5 Sep 2019 06:41:46 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44608 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731215AbfIEKlp (ORCPT ); Thu, 5 Sep 2019 06:41:45 -0400 Received: from localhost (unknown [89.248.140.11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DB81B15388142; Thu, 5 Sep 2019 03:41:44 -0700 (PDT) Date: Thu, 05 Sep 2019 12:41:43 +0200 (CEST) Message-Id: <20190905.124143.72972869920021226.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] r8152: adjust the settings of ups flags From: David Miller In-Reply-To: <1394712342-15778-328-Taiwan-albertk@realtek.com> References: <1394712342-15778-327-Taiwan-albertk@realtek.com> <1394712342-15778-328-Taiwan-albertk@realtek.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Sep 2019 03:41:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang Date: Thu, 5 Sep 2019 10:46:20 +0800 > The UPS feature only works for runtime suspend, so UPS flags only > need to be set before enabling runtime suspend. Therefore, I create > a struct to record relative information, and use it before runtime > suspend. > > All chips could record such information, even though not all of > them support the feature of UPS. Then, some functions could be > combined. > > Signed-off-by: Hayes Wang Applied.