Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030297AbVLVUuZ (ORCPT ); Thu, 22 Dec 2005 15:50:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030282AbVLVUuZ (ORCPT ); Thu, 22 Dec 2005 15:50:25 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:9602 "EHLO palinux.hppa") by vger.kernel.org with ESMTP id S965184AbVLVUuY (ORCPT ); Thu, 22 Dec 2005 15:50:24 -0500 Date: Thu, 22 Dec 2005 13:50:23 -0700 From: Matthew Wilcox To: Mark Maule Cc: Greg KH , linuxppc64-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Luck Subject: Re: [PATCH 0/3] msi abstractions and support for altix Message-ID: <20051222205023.GK2361@parisc-linux.org> References: <20051222201651.2019.37913.96422@lnx-maule.americas.sgi.com> <20051222202259.GA4959@suse.de> <20051222202627.GI17552@sgi.com> <20051222203415.GA28240@suse.de> <20051222203824.GJ17552@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051222203824.GJ17552@sgi.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 21 On Thu, Dec 22, 2005 at 02:38:24PM -0600, Mark Maule wrote: > Because on ia64 IA64_FIRST_DEVICE_VECTOR and IA64_LAST_DEVICE_VECTOR > (from which MSI FIRST_DEVICE_VECTOR/LAST_DEVICE_VECTOR are derived) are not > constants. The are now global variables (see change to asm-ia64/hw_irq.h) > to allow the platform to override them. Altix uses a reduced range of > vectors for devices, and this change was necessary to make assign_irq_vector() > to work on altix. To be honest, I think this is just adding a third layer of paper over the crack in the wall. The original code assumed x86; the ia64 port added enough emulation to make it look like x86 and now altix fixes a couple of assumptions. I say: bleh. What we actually need is an interface provided by the architecture that allocates a new irq. I have a hankering to implement MSI on PA-RISC but haven't found the time ... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/